-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed v3.2.4 #28
base: master
Are you sure you want to change the base?
Proposed v3.2.4 #28
Conversation
Update on ACF v6 UI issues for the number field with append gap issue, and color_picker button size issue: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codejp3 Can you please fix little spacing and indentation issues? Thanks
Let me know if anything else needs changing. |
@mujahidi - Tested and ready for final review.
It may seem like a lot, but the bulk majority of it is just code cleanup with tabs/spaces for easier readability.
I've tested against ACF v5 & v6. Both are functioning properly, but I found 2 UI visual bugs with v6:
I figured you may want to change some of the wording for things. That's why it will be the NEXT release that officially supports translations ( #24 ) after you re-word anything to your liking. This release was just getting it prepared for it.
Highlights for actual code changes:
functions.php:
-- one handles post_id stuff and fixes the issue with trying to get an id of a non-object (WP Support topic)
-- one handles getting the values for fields (based on valid post_id)
-- one handles merging the values for fields (based on supplied values)
-- one handles enqueueing the stylesheet (based on merged values)
admin_settings.php
acf-typography.php
acf-Typography-v5.php
acf-Typography-v6.php
That's really about it. Everything else is superficial, minor code cleanup, and has zero impact on functionality.