Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status bar behaviour changes when exiting the full screen. #21

Open
kunwar231 opened this issue May 28, 2020 · 14 comments
Open

status bar behaviour changes when exiting the full screen. #21

kunwar231 opened this issue May 28, 2020 · 14 comments
Labels
help wanted Extra attention is needed

Comments

@kunwar231
Copy link

When exiting the full screen view, the status bar gets hidden. Status bar is not set as per a single view controller in the info.plist, so its not possible for me to update it for a single viewcontroller.

@mukeshydv
Copy link
Owner

Can you share some more details, like a screen shot of current behavior and desired behavior?

@kunwar231
Copy link
Author

I added the player in a viewcontroller and pushed this viewcontroller from another viewcontroller on an action. Now when I play the video, it expands to full screen. In the full screen view, if I tap on the cross button in the top left of the screen, the player exits the full screen but the status bar in the viewcontroller now gets hidden. My viewcontroller also has a navigationbar

@kunwar231
Copy link
Author

@mukeshydv please suggest a solution

@kunwar231
Copy link
Author

It's not an issue in the simulator but in the devices. Checked in iphone 6, 8 and Xr

@mukeshydv
Copy link
Owner

can you paste code of your viewcontroller which has video view?

@kunwar231
Copy link
Author

kunwar231 commented May 28, 2020 via email

@mukeshydv
Copy link
Owner

try adding this code in the video view controller

    override var prefersStatusBarHidden: Bool {
        return false
    }

@kunwar231
Copy link
Author

kunwar231 commented May 31, 2020 via email

@mukeshydv
Copy link
Owner

@kunwar231
Copy link
Author

Setting viewcontroller based status bar to true is still required to call prefersstatusbarhidden. And why have you closed the issue, when it's not resolved?

@kunwar231 kunwar231 changed the title status bar behaviour changes when exiting the full screen status bar behaviour changes when exiting the full screen.Issue not fixed Jun 1, 2020
@mukeshydv
Copy link
Owner

@mukeshydv mukeshydv added wontfix This will not be worked on and removed wontfix This will not be worked on labels Jun 1, 2020
@kunwar231
Copy link
Author

kunwar231 commented Jun 1, 2020 via email

@mukeshydv
Copy link
Owner

I'm busy for some time, can you open a PR with the fix? thanks.

@kunwar231
Copy link
Author

kunwar231 commented Jun 4, 2020 via email

@mukeshydv mukeshydv reopened this Jun 4, 2020
@mukeshydv mukeshydv added the help wanted Extra attention is needed label Jun 4, 2020
@mukeshydv mukeshydv changed the title status bar behaviour changes when exiting the full screen.Issue not fixed status bar behaviour changes when exiting the full screen. Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants