fix(decoder): should reset crc16 when file's crc is 0 #221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d.fileHeader.CRC == 0x0000
, it means the FIT file might be using legacy header (12 bytes) so there is no crc integrity for thefile_header
. However, thefile_crc
that will validate the integrity of the messages should be present. We should reset thed.crc16
before returning nil, otherwise the calculation of the messages' crc might mismatch sinced.crc16
is still containing file_header's crc calculation. (We don't need resetd.crc16
on error)