Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: proto.Any will no longer allocate slice #271

Merged
merged 1 commit into from
May 16, 2024

Conversation

muktihari
Copy link
Owner

@muktihari muktihari commented May 16, 2024

  • proto.Any will no longer allocate slice when v is a slice of non-primitive-type.
  • proto.Any will no longer return proto.Value with TypeInvalid when v is a slice of non-primitive-type with zero length.

@muktihari muktihari added the performance Changes related to performance improvement label May 16, 2024
@muktihari muktihari self-assigned this May 16, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (358ed0a) to head (69bf3bb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #271   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         3649      3612   -37     
=========================================
- Hits          3649      3612   -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muktihari muktihari changed the title perf: proto.Any will no longer allocate perf: proto.Any will no longer allocate slice May 16, 2024
@muktihari muktihari merged commit b0f073d into master May 16, 2024
4 checks passed
@muktihari muktihari deleted the perf/proto-any-reflect branch May 16, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Changes related to performance improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants