Add Jane Street coding style linter

mukul-rathi · Nov 9, 2019 · 7b9773a · 7b9773a
1 parent c8fec2e
commit 7b9773a
Show file tree

Hide file tree

Showing 7 changed files with 19 additions and 3 deletions.
diff --git a/.gitignore b/.gitignore
@@ -7,6 +7,7 @@
 *.cmx
 *.cmxs
 *.cmxa
+*.install
 
 # ocamlbuild working directory
 _build/

diff --git a/.travis.yml b/.travis.yml
@@ -4,7 +4,7 @@ script:
   - bash -ex .travis-ocaml.sh
   - eval $(opam config env)
   - make install
-  - dune build @fmt
+  - make lint
   - make test
   - make coverage
   - bisect-ppx-report send-to Coveralls

diff --git a/Makefile b/Makefile
@@ -2,9 +2,16 @@ default:
 	opam install . --deps-only
 	dune build
 
+build:
+	dune build
+
 install:
 	opam install --yes . --deps-only
 
+lint:
+	dune build @lint
+	dune build @fmt
+
 test:
 	dune runtest 
 

diff --git a/hello_world.opam b/hello_world.opam
@@ -17,6 +17,7 @@ depends: [
   "odoc"
   "ocamlformat"
   "bisect_ppx" {dev & >= "2.0.0"}
+  "ppx_js_style"
 ]
 
 pin-depends: [

diff --git a/hooks/pre-commit b/hooks/pre-commit
@@ -1,3 +1,4 @@
 #!/bin/sh
 make format
+make lint
 make clean
diff --git a/src/dune b/src/dune
@@ -1,4 +1,7 @@
 (library
  (public_name hello_world)
  (preprocess
-  (pps bisect_ppx --conditional)))
+  (pps bisect_ppx --conditional))
+ (lint
+  (pps ppx_js_style -check-doc-comments -annotated-ignores -styler -pretty
+    -dated-deprecation)))
diff --git a/tests/dune b/tests/dune
@@ -1,3 +1,6 @@
 (test
  (name test_hello_world)
- (libraries hello_world alcotest qcheck qcheck-alcotest))
+ (libraries hello_world alcotest qcheck qcheck-alcotest)
+ (lint
+  (pps ppx_js_style -check-doc-comments -annotated-ignores -styler -pretty
+    -dated-deprecation)))