Minor Fixes

mukulmantosh · Nov 6, 2023 · 47d7051 · 47d7051
1 parent 5976c66
commit 47d7051
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 16 deletions.
diff --git a/k8s/gke/app/app-cm.yml b/k8s/gke/app/app-cm.yml
@@ -4,10 +4,11 @@ metadata:
   name: app-cm
   namespace: go-ecommerce
 data:
-  JWT_SECRET: "secret"
-  DB_HOST: "database-service"
-  DB_USERNAME: "postgres"
-  DB_PASSWORD: "sample123"
-  DB_NAME: "ecommerce"
-  DB_PORT: "5432"
+  JWT_SECRET: "*********"               # Provide Random Secret Text
+  DB_HOST: "database-service"           # Name of service db-service (refer db-service.yml)
+  DB_USERNAME: "**********"             # Database Username
+  DB_PASSWORD: "*********"              # Database Password
+  DB_NAME: "**********"                 # Database Name
+  DB_PORT: "*********"                  # Database Port
 
+# Production Recommend: Kubernetes Secrets, External Secret Management Tool.
diff --git a/k8s/local/app/app-cm.yml b/k8s/local/app/app-cm.yml
@@ -4,10 +4,9 @@ metadata:
   name: app-cm
   namespace: go-ecommerce
 data:
-  JWT_SECRET: "secret"
-  DB_HOST: "postgres-service"
-  DB_USERNAME: "sample"
-  DB_PASSWORD: "sample123"
-  DB_NAME: "ecommerce"
-  DB_PORT: "5432"
-
+  JWT_SECRET: "*********"               # Provide Random Secret Text
+  DB_HOST: "postgres-service"           # Name of service (refer db/service.yml)
+  DB_USERNAME: "**********"             # Database Username
+  DB_PASSWORD: "*********"              # Database Password
+  DB_NAME: "**********"                 # Database Name
+  DB_PORT: "*********"                  # Database Port
diff --git a/k8s/local/db/cm.yml b/k8s/local/db/cm.yml
@@ -6,6 +6,6 @@ metadata:
   labels:
     app: postgres
 data:
-  POSTGRES_DB: "ecommerce"
-  POSTGRES_USER: "sample"
-  POSTGRES_PASSWORD: "sample123"
+  POSTGRES_DB: "***********"              # DB NAME
+  POSTGRES_USER: "***********"            # DB USERNAME
+  POSTGRES_PASSWORD: "***********"        # DB PASSWORD