-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2.7.2 release #85
Merged
Merged
V2.7.2 release #85
Changes from 21 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
d9fb100
better error handling
mukunku 9993f4e
better list exception handling based on error logs
mukunku 3c557c3
don't log invalid query exceptions
mukunku 87532f5
bump assembly version
mukunku 3db1357
better io exception handling
mukunku 51704a5
exception cleanup
mukunku 7ea551c
fix list type check
mukunku 0389fe0
add column metadata to rowgroup metadata
mukunku 5aa945a
loosen list schema validation
mukunku e1f60c8
update parquet.net library
mukunku 0804119
remove statistics and encoding stats for now unless someone needs them
mukunku c379c99
intercept byte[] fields and render them as strings
mukunku d2ff2d5
bump assembly version to 2.7.2.1
mukunku 40be835
some minor cleanup
mukunku 330bc83
change default columns size mode to all cells
mukunku 1faa99d
add copy raw button for thrift metadata and remove rowgroup details a…
mukunku 5c4d7e2
update parquet.net package
mukunku 29cb2e7
some cleanup
mukunku b3b2806
Update README.md
mukunku 080226b
Update README.md
mukunku 436992b
add fix for malformed datetime
mukunku 51cc9fe
update packages and assembly version
mukunku 2dd4a51
start tracking selfcontained executable usage
mukunku ca4b5ab
fix unit test
mukunku abfad6a
fix the test for realz this time
mukunku 854bb0d
Add "SC" suffix to version number in about box for self contained dep…
mukunku File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange that you need to work with such a patch...
Was it already here before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I shared some details on your issue ticket, I believe the timestamp field is malformed which is why it's being shown as a epoch value instead of datetime.
I added a patch so we can still open such fields in the app for now. These types of inconsistencies tend to get resolved over time so I'm hoping that will be the case with this issue. I added a unit test to detect this as well.
We used to handle timestamp fields directly in the app but the
parquet-dotnet
library had added support for internally handling DateTime fields so we got rid of the logic from the app. But if the metadata is malformed of course that library doesn't handle it as a DateTime. So I added the old logic back for now.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I am wondering which package doesn't write away the metadata correctly.
It's made with
pandas
, but that is juste a wrapper topyarrow
- the python implementation ofApache Arrow
, a package from the creators ofApache Parquet
.So strange... or it's on the
parquet-dotnet
side.I'll see if I need to open another bug somewhere else.
Thanks