Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkey ot Trun on/off keyviz and special Shortcut key #41

Closed
baxing opened this issue Aug 30, 2022 · 9 comments
Closed

Hotkey ot Trun on/off keyviz and special Shortcut key #41

baxing opened this issue Aug 30, 2022 · 9 comments
Labels
duplicate This issue or pull request already exists ✨ enhancement New feature or request

Comments

@baxing
Copy link

baxing commented Aug 30, 2022

Hello,
Your keyviz's beautiful and great, I love it. But I have to offer more. that would like you to add

  1. If I want to Turn on or off the keyviz I need to use mouse click only, Can you custom shortkey by user to turn on-off it?If you can make this shortcut into a shortcut that doesn't need to be displayed as well (filter)

  2. In VSCode have some short key such (Ctrl+K T, Ctrl+K Ctrl+T) this is sequence shortkey, Can you add this option?

  3. Can you add check box for other key such (F1-F12, Shift + F1-Shift + F12)? this is useful.

If you find it helpful, please do so with these requests.
Thank you

@mulaRahul mulaRahul added ✨ enhancement New feature or request duplicate This issue or pull request already exists labels Aug 31, 2022
@mulaRahul
Copy link
Owner

  1. If I want to Turn on or off the keyviz I need to use mouse click only, Can you custom shortkey by user to turn on-off it?

It's already planned and been tracked in #35.

If you can make this shortcut into a shortcut that doesn't need to be displayed as well (filter).

This may not be good idea if the hotkey is something like Ctrl+ O, then every hotkey starting with Ctrl needs to checked (i.e. not efficient) and also wait for the second key like O in this case, before visualizing the same (assuming that the hotkey in question shouldn't be displayed).

But if the shortcut is something like F6 or Pause, then it's possible (as they are rarely used). The user can select a key/s (which they don't need to display) to pause/resume the visualizer. What is your opinion?

In VSCode have some short key such (Ctrl+K T, Ctrl+K Ctrl+T) this is sequence shortkey, Can you add this option?

This is also suggested before in discussion #34.

Can you add check box for other key such (F1-F12, Shift + F1-Shift + F12)? this is useful.

and this too in #40. Currently, the hotkey filter, filter outs the shortcuts starting with Shift and function keys. I will let the user decide whether to ignore them or not.

@baxing
Copy link
Author

baxing commented Aug 31, 2022

If you can make this shortcut into a shortcut that doesn't need to be displayed as well (filter).

I mean the shortcut which set for turn on/off visualize maybe not need to show keystroke (such user set Shoft+F12 for on/off visualize, so this shortkey maybe not show keystroke)

In VSCode have some short key such (Ctrl+K T, Ctrl+K Ctrl+T) this is sequence shortkey

My mean this is not history of ketstroke but it is sequence of shortkey such in VSCode Ctrl+K S for Save all, then keystrike should be show Ctrl+K S in same line

Can you add check box for other key such (F1-F12, Shift + F1-Shift + F12)? this is useful.

Thank you for use can custom hotkey filter, this is goof idea

Thank you

@mulaRahul
Copy link
Owner

My mean this is not history of ketstroke but it is sequence of shortkey such in VSCode Ctrl+K S for Save all, then keystrike should be show Ctrl+K S in same line

do you mean this -

ctrl-k-s.mp4

@baxing
Copy link
Author

baxing commented Aug 31, 2022

This is my setup for show keystroke only shortcut(do not show any keys)
setup

This is sample chart of VSCode shortcuts
shortcut chart

Please see these my short clips :

  1. If I want to show "Keyboard Shortcuts" in VSCode, I need press Ctrl+K Ctrl+S
  • step A: Ctrl+K and release all buttons,
  • step B: Then press Ctrl+S
1-.Ctrl+K_Ctrl+S.mp4

--> This is OK

Or
2. If I want to show "Keyboard Shortcuts" in VSCode, I need press Ctrl+K Ctrl+S

  • step A: press Ctrl+K and release K button but but still hold down the Ctrl key
  • step B: and then press S key
2-Ctrl+K_Ctrl+S.mp4

--> This is I think OK

But
3. If I want to "Save All" in VSCode, I need press Ctrl+K S

  • step A: press Ctrl+K and release all buttons,
  • step B: Then press S key
3-Ctrl+K.S.mp4

--> This is I think not OK because keystroke not show S key in same line

@mulaRahul
Copy link
Owner

mulaRahul commented Sep 1, 2022

  1. If I want to "Save All" in VSCode, I need press Ctrl+K S

You cannot achieve the same with hotkey filter turned on because it filters out the letters like

  • press Ctrl+K and then release them, it will be shown
  • and then press S, it will be ignored

Now what you're saying is possible to implement, but for that, a new listener needs to be set up to check the history before displaying/ignoring each newly pressed key. It's not efficient and practical at all, as it will mean adding a new layer of complexity for just a software-specific feature. I hope you get my point.

Alternatively, you can use the Append mode for this and turn off the Hotkey filter -

append-mode.mp4

@baxing
Copy link
Author

baxing commented Sep 1, 2022

Hi,

For your clip, not use Hotkey filter. It will result in the display of the key on every key pressed, which may not be a requirement to show only the hotkeys.

I apologize for my comment, if in your opinion thst it is not possible.
But before I found your software. I found mouse-cursor-highlight-windows.

https://github.com/yunyi-the-coder/mouse-cursor-highlight-windows

And i have tested it. I found that the keyboard shortcut Ctrl+K S can be displayed, so I thought it might be possible.
Let me show you a clip comparing the mouse-cursor-highlight-windows(Keystroke) with Keyviz as follows for display shortcut Ctrl+K S

Compare.mp4

thank you

@mulaRahul
Copy link
Owner

The mouse-cursor-highlight-windows achieves the same with regular expressions (I guess). As you can see, in mouse-cursor-highlight-windows the corresponding key text is displayed on the screen (minimal) but with keyviz, each key is converted into a keycap/widget and then displayed.

Both software does the same thing i.e. display keypresses, but the underlying code to achieve the same is completely different. With the current workflow (algorithm if you will) of keyviz, that's not possible 😓. It will mean, changing things from the ground up.

I apologize for my comment, if in your opinion thst it is not possible.

You're always welcome to share your thoughts/suggestions! I'll try to implement them to the best of my ability 🙂. Though there are many things that my tiny brain can't comprehend 😅.

@baxing
Copy link
Author

baxing commented Sep 1, 2022

Thank you

If in the future you will be able to make keyviz support shortkey like Ctrl+K S (in Hotkey filter mode) I will be very pleased. But for me right now your program is awesome and beautiful. Only if there are a few tweaks to support some of the things I offer (if possible) and support for multi-screen cases. (Choose which screen to display) It would be a perfect submission in my opinion.
🥇

@mulaRahul
Copy link
Owner

Hello @baxing, I've planned to add the history view, like (mentioned above)

Ctrl + K
Ctrl + Shift + O

in the upcoming release! (more here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists ✨ enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants