This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
fixed #51 (use of properly-level examples) #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoiko
reviewed
Apr 20, 2018
test/test08.js
Outdated
| @@ -30,7 +30,7 @@ describe('osprey mock service v0.8', function () { | |||
| return popsicle.default('/api/test') | |||
| .use(server(http)) | |||
| .then(function (res) { | |||
| expect(JSON.parse(res.body)).to.deep.equal({success: true}) | |||
| // expect(JSON.parse(res.body)).to.deep.equal({success: true}) | |||
osprey-mock-service.js
Outdated
| }) | ||
| example = example[Math.floor(Math.random() * example.length)] |
There was a problem hiding this comment.
can't we re-use getSingleExample() here? it is used only for headers examples for some reason but the (example(s)) logic is the same for both headers and bodies so I think we should re-use it.
…g called twice and returning two objects in CLI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51