[W-] Update font-family to use Lume font stack #828
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lume Font Migration
ToDo:
Background
As we continue our mission to evolve our visual language and drive consistency across our platform UX, one of the guiding principles of the changes we’re rolling out is that we do it with minimal disruption to product teams. To that end, the UX Engineering team created this automated PR to facilitate the next phase of our effort to migrate the Anypoint Platform away from custom fonts in favor of system fonts, and to use the new font stacks defined by the Lume UXD team. Specifically, the changes in this PR replace out of compliance hard-coded
font-familyCSS code with styling hooks (aka, CSS custom properties) corresponding to--lume-g-font-family-codefor codeblocks or--lume-g-font-familyfor everything else.As this is an automated PR and we can't account for every edge case. Please completely review the PR before merging it.
There could be instances where the PR is replacing test files or other non relevant files, in which case your team would have to make sure the replace should remain or not.
Finally, make sure you're bundling the Lume styling hooks with your application so that the above styling hooks can get their values assigned at runtime.
If this application is not yet using the Lume styling hooks, you can do that in two different ways:
anypoint-stylesmake sure to upgrade it to the latest version v5.x.x (v5.0.1 as of the time of this PR) and that will include all the necessary styling hooks.anypoint-stylesor cannot upgrade to the required version, install the latest version of the package@mulesoft/lume-styling-hooks(v0.1.47 as of the time of this PR) and include the CSS@mulesoft/lume-styling-hooks/dist/index.cssin this application bundle.As always, don't hesitate to contact our team at #ms-ux-engineering-trust for guidance or to ask questions.