Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin watches the wrong application when more then one application has the same name #353

Open
ullgren opened this issue Dec 16, 2019 · 1 comment

Comments

@ullgren
Copy link

ullgren commented Dec 16, 2019

When more than one application (deployment) has the same name and one of them is deployed to runtime fabcric there is a chance that the mule maven plugin will wait for the wrong deployment to become ready.

This scenario is possible when you have two applications with the same name in the same environment and one of the applications are on a runtime fabric and the other is on a standalone server. This will result in a faulty timeout when since the expected deployment status for a runtime fabric application will never occur when the mule maven plugin checks the status of the stand alone application.

Reproduce

  • Make sure to have one stand alone server and a runtime fabric cluster in the same environment
  • Create a new application names "echo" deploy it to one of the standalone server
  • Using the mule maven plugin deploy the same application with the same application name ("echo") to the runtime fabric cluster.
  • Even if the deployment is successful the mule maven plugin will timeout since it tries to track the deployment on the standalone server.

Expected result

The mule maven plugin should verify that it is tracking the deployment it just created, not just a deployment with the same name.

Reference to code:
https://github.com/mulesoft/mule-maven-plugin/blob/2.x/mule-deployer/src/main/java/org/mule/tools/verification/fabric/RuntimeFabricDeploymentVerification.java#L71
https://github.com/mulesoft/mule-maven-plugin/blob/3.x/mule-deployer/src/main/java/org/mule/tools/verification/fabric/RuntimeFabricDeploymentVerification.java#L79

@ullgren
Copy link
Author

ullgren commented Dec 16, 2019

Compare how the ArmClient find the application id taking target id into consideration

https://github.com/mulesoft/mule-maven-plugin/blob/3.x/mule-deployer/src/main/java/org/mule/tools/client/arm/ArmClient.java#L217-L222

ullgren added a commit to ullgren/mule-maven-plugin that referenced this issue Dec 16, 2019
ullgren added a commit to ullgren/mule-maven-plugin that referenced this issue Jun 10, 2020
ullgren added a commit to ullgren/mule-maven-plugin that referenced this issue Nov 15, 2020
ullgren added a commit to ullgren/mule-maven-plugin that referenced this issue Feb 9, 2022
ullgren added a commit to ullgren/mule-maven-plugin that referenced this issue Feb 10, 2022
ullgren added a commit to ullgren/mule-maven-plugin that referenced this issue Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant