Switch build system from cmake to cc #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for updating this crate @jasperdewinther. I have updated the CI, would you mind rebasing to try if building the crate works on mac/windows/linux? I notice c-blosc is not at 1.21.2, would you mind using this release? There might be a problem linking lz4/zlib/zstd when also using |
|
Thanks! I will add some additional CI jobs for feature checking and merge when I am back at a computer |
|
I messed up a push to your repo @jasperdewinther and moved the PR a branch on this repo |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the build system from cmake to cc to simplify dependency management. lz4, zlib and zstd are all being compiled and can be used.
Also bumped c-blosc version.