Stricter cargo audit (deny warnings) #4322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faern
force-pushed
the
stricter-cargo-audit
branch
from
e3e1181
to
a2e2e42
Compare
pinkisemils
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
Reviewed 5 of 7 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
faern
force-pushed
the
stricter-cargo-audit
branch
from
a2e2e42
to
1590d71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do explicitly ignore
RUSTSEC-2021-0145. But that CVE is only an info level warning, so justcargo auditdid not trigger an error on it anyway.--deny warningswas needed for that. This PR makes our audit check stricter by denying all warnings.This means that minor stuff such as unmaintained dependencies will trigger an error. That can be annoying. But I figure we can then explicitly add that CVE to this list when it happens. I think that's better than silently ignoring warnings. This way we will get flagged when something is unmaintained etc and we can act on it.
This PR fixes a warnings we had: Upgrade
bumpaloto avoid RUSTSEC-2022-0078I also upgrade
env_logger. Since we were mentioning that as a blocker for not ignoringRUSTSEC-2021-0145butenv_loggerhas already fixed the issue, I figured we better upgrade. We are still pulling inattyagainst our will in a few places, but now they are at least fewer.This change is