Enable DAITA settings on linux #6184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlon
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
talpid-types/src/net/wireguard.rs line 66 at r1 (raw file):
#[cfg(any(target_os = "windows", target_os = "linux"))] #[serde(skip)] pub constant_packet_size: bool,
This is still unused on Linux, right?
Serock3
commented
Apr 29, 2024
There was a problem hiding this comment.
Reviewable status:
talpid-types/src/net/wireguard.rs line 66 at r1 (raw file):
Previously, dlon (David Lönnhager) wrote…
This is still unused on Linux, right?
True, that was an oversight on my part. On the other hand, none of the other DAITA functionality is implemented in this PR either. If we exclude constant packet size, we have to make a separate PR just for enabling that.
Serock3
force-pushed
the
daita-wireguard-go
branch
from
1f8073e
to
ccf0e7f
Compare
Serock3
force-pushed
the
enable-daita-on-windows
branch
2 times, most recently
from
9033a46
to
34f5258
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that there is a typo in the branch name, please ignore that
To make the review process easier, this first PR just merges the changes needed to enable DAITA in the CLI, GUI and settings.
Fixes DES-843 and DES-844
This change is