Reorganise MullvadVPNTests hierarchy to match hierarchy of code under test #6185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acb-mv
requested review from
niklasberglund,
rablador,
pinkisemils,
buggmagnet and
mojganii
acb-mv
force-pushed
the
unit-tests-reorganise-mullvadvpntests-code-hierarchy-to-ios-540
branch
from
0e2ca9f
to
d17a151
Compare
rablador
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Reviewed 49 of 49 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
pinkisemils
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
pinkisemils
force-pushed
the
unit-tests-reorganise-mullvadvpntests-code-hierarchy-to-ios-540
branch
from
d17a151
to
3ea4735
Compare
pinkisemils
deleted the
unit-tests-reorganise-mullvadvpntests-code-hierarchy-to-ios-540
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reorganises the files under
MUllvadVPNTests, from a largely flat structure, to a structure mirroring the code under test. Both test code and mocks/stubs specific to code under test are moved to the respective groups. This will aid in the organisation of tests going forward.This change is