Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PacketTunnelActor's state logic to use a Reducer #6194

Closed
wants to merge 44 commits into from
Closed

Refactor PacketTunnelActor's state logic to use a Reducer #6194

wants to merge 44 commits into from

Commits on Apr 10, 2024

  1. Add FFI to talpid-tunnel-config-client

    @pinkisemils @buggmagnet
    pinkisemils authored and buggmagnet committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    649497a View commit details
    Browse the repository at this point in the history

  2. Remove debug statements

    @buggmagnet
    buggmagnet committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    f52beed View commit details
    Browse the repository at this point in the history

  3. Regroup switch cases together

    @buggmagnet
    buggmagnet committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    8976610 View commit details
    Browse the repository at this point in the history

  4. Enable reading Quantum Resistance settings from SettingsReader

    @buggmagnet
    buggmagnet committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    8b39afc View commit details
    Browse the repository at this point in the history

  5. Add utility methods for mutating State's data, replacing switch stmts

    @acb-mv @buggmagnet
    acb-mv authored and buggmagnet committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    3179d42 View commit details
    Browse the repository at this point in the history

  6. Remove premature changes not related to this refactoring

    @acb-mv @buggmagnet
    acb-mv authored and buggmagnet committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    276cc26 View commit details
    Browse the repository at this point in the history

  7. Remove commented dead code

    @acb-mv @buggmagnet
    acb-mv authored and buggmagnet committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    dd92cd5 View commit details
    Browse the repository at this point in the history

  8. Make State Equatable, move change checks to didSet &c

    @acb-mv @buggmagnet
    acb-mv authored and buggmagnet committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    a40039c View commit details
    Browse the repository at this point in the history

  9. Add a new actor state for key negotiation

    @buggmagnet
    buggmagnet committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    a345a93 View commit details
    Browse the repository at this point in the history

  10. Read settings to determine whether to exchange a PQ key

    @buggmagnet
    buggmagnet committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    7a61e31 View commit details
    Browse the repository at this point in the history

  11. Try to reconnect when PQ key exchange fails

    @buggmagnet
    buggmagnet committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    dfbb65b View commit details
    Browse the repository at this point in the history

  12. Remove dead code

    @buggmagnet
    buggmagnet committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    a52f732 View commit details
    Browse the repository at this point in the history

  13. Enable exchanging PQ keys from an unconnected state

    @buggmagnet
    buggmagnet committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    bc9fd28 View commit details
    Browse the repository at this point in the history

  14. Add safety checks at the FFI boundary

    @buggmagnet
    buggmagnet committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    03c355d View commit details
    Browse the repository at this point in the history

  15. Remove unneeded dependencies

    @buggmagnet
    buggmagnet committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    3f96f3b View commit details
    Browse the repository at this point in the history

  16. Tidy code around key negotiation and cancellation token flow

    @acb-mv @buggmagnet
    acb-mv authored and buggmagnet committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    0678902 View commit details
    Browse the repository at this point in the history

  17. Add "tidy" as an imperative verb

    @acb-mv @buggmagnet
    acb-mv authored and buggmagnet committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    64ed90f View commit details
    Browse the repository at this point in the history

  18. Update git-commit-message-style to match main

    @acb-mv @buggmagnet
    acb-mv authored and buggmagnet committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    4b94b3a View commit details
    Browse the repository at this point in the history

  19. Fix a typo

    @buggmagnet
    buggmagnet committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    caa3c4d View commit details
    Browse the repository at this point in the history

  20. Remove unneeded framework reference

    @buggmagnet
    buggmagnet committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    5ddbac4 View commit details
    Browse the repository at this point in the history

  21. Rewrite the PQ cancellation token in a safer way

    @buggmagnet
    buggmagnet committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    5a6e3fb View commit details
    Browse the repository at this point in the history

  22. Fix rebase issues

    @buggmagnet
    buggmagnet committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    d7a41e3 View commit details
    Browse the repository at this point in the history

  23. Add a method to receive the preshared key in the actor

    @buggmagnet
    buggmagnet committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    592c887 View commit details
    Browse the repository at this point in the history

  24. Add preSharedKey to configurationBuilder

    @acb-mv
    acb-mv committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    6bf5086 View commit details
    Browse the repository at this point in the history

  25. Attempt at starting a tunnel with the PQ shared key

    @acb-mv
    acb-mv committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    2beed87 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Hack the new private key as a global to prove PQ PSK works

    @buggmagnet
    buggmagnet committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    ef294a1 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Prototype a new actor to handle PQ PSK

    @buggmagnet
    buggmagnet committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    82efde9 View commit details
    Browse the repository at this point in the history

  2. Add the ephemeral private key to the negotiation data flow (Swift-sid… 

    …e only; Rust needs work)
    @acb-mv
    acb-mv committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    d8cc4d4 View commit details
    Browse the repository at this point in the history

  3. Pass the ephemeral key to postQuantumConnect

    @acb-mv
    acb-mv committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    7562414 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Modify (partially) Rust code to handle the ephemeral key as passed th… 

    …rough
    @acb-mv
    acb-mv committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    84d7dca View commit details
    Browse the repository at this point in the history

  2. Derive the ephemeral public key from the private key in the FFI

    @buggmagnet
    buggmagnet committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    856d522 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Correct spelling of PostQuantumKeyNegotiator

    @acb-mv
    acb-mv committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    31682fd View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Add functionality to the actor

    @acb-mv
    acb-mv committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    55dc2f4 View commit details
    Browse the repository at this point in the history

  2. Move PQ negotiation to Actor which is now not an Actor

    @acb-mv
    acb-mv committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    62f49cd View commit details
    Browse the repository at this point in the history

  3. Refactor PQ key receiving protocol

    @acb-mv
    acb-mv committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    61c6908 View commit details
    Browse the repository at this point in the history

  4. Fix whitespace

    @acb-mv
    acb-mv committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    d26cfa5 View commit details
    Browse the repository at this point in the history

  5. Combine all negotiation-lifecycle data in one optional struct

    @acb-mv
    acb-mv committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    ee0f4a0 View commit details
    Browse the repository at this point in the history

  6. Remove obsolete code from PacketTunnelProvider

    @acb-mv
    acb-mv committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    edb394f View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Do not schedule more than one read or writes at a time

    @buggmagnet
    buggmagnet committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    eb37a8d View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Transfer PacketTunnelActor state-logic to a stateless reducer function

    @acb-mv
    acb-mv committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    f126cd3 View commit details
    Browse the repository at this point in the history

  2. Separate PacketTunnelActor state logic into a reducer and effect exec… 

    …utor
    @acb-mv
    acb-mv committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    b771d93 View commit details
    Browse the repository at this point in the history

  3. Clarify Effect values

    @acb-mv
    acb-mv committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    894a1bd View commit details
    Browse the repository at this point in the history

  4. Add tests to the Reducer

    @acb-mv
    acb-mv committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    e2d9590 View commit details
    Browse the repository at this point in the history

  5. Add tests to the Reducer

    @acb-mv
    acb-mv committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    6c37945 View commit details
    Browse the repository at this point in the history