Add reset command

[pinkisemils]

Add CLI command to remove daemon settings, clear the cache and logs.

---

This change is 

[jvff]

Reviewed 8 of 8 files at r1.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @pinkisemils)

---

mullvad-cli/src/cmds/reset.rs, line 3 at r1 (raw file):

use crate::{new_rpc_client, Command, Result};
use std::io::stdin;
pub struct Reset;

Nit: Could you add a newline to separate the imports from the struct?

---

mullvad-cli/src/cmds/reset.rs, line 30 at r1 (raw file):

impl Reset {
    fn receive_confirmation() -> bool {
        println!("Are you sure you want to disconnect, log out, delete all settings, logs and cache files for the Mullvad VPN system service? [y/N]");

Minor: Maybe change the input hint so that it's something like [Yes/No (default)]?

---

mullvad-daemon/src/lib.rs, line 108 at r1 (raw file):

    RemovalError(#[error(cause)] io::Error),

    #[error(display = "Failed to remove directory")]

Missing update to command description.

---

mullvad-daemon/src/lib.rs, line 947 at r1 (raw file):

    fn on_factory_reset(&mut self, tx: oneshot::Sender<()>) {
        // Disconnect to ensure that log files won't be rotated into the new log directories
        self.set_target_state(TargetState::Unsecured);

Should the code wait for the tunnel to disconnect before starting the factory reset? Not sure if the logs would get written with something while disconnecting.

---

mullvad-daemon/src/lib.rs, line 969 at r1 (raw file):

            failed = true;
        }
        if !failed {

Nit: Maybe also add a newline here? 🤔

---

mullvad-types/src/settings.rs, line 29 at r1 (raw file):

    ReadError(String, #[error(cause)] io::Error),

    #[error(display = "Unable to remove settings file")]

Shouldn't the settings file path be printed here?

[pinkisemils]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @jvff)

---

mullvad-daemon/src/lib.rs, line 108 at r1 (raw file):

Previously, jvff (Janito Vaqueiro Ferreira Filho) wrote…

Missing update to command description.

Done.

---

mullvad-daemon/src/lib.rs, line 947 at r1 (raw file):

Previously, jvff (Janito Vaqueiro Ferreira Filho) wrote…

Should the code wait for the tunnel to disconnect before starting the factory reset? Not sure if the logs would get written with something while disconnecting.

Nah, I don't believe there's actually any risk. I ran into issues during testing due to the log directories being wholly removed. But I resolved that issue. I'm not sure whether waiting or disconnecting at all here makes any sense.

---

mullvad-types/src/settings.rs, line 29 at r1 (raw file):

Previously, jvff (Janito Vaqueiro Ferreira Filho) wrote…

Shouldn't the settings file path be printed here?

Done.

[jvff]

Reviewed 3 of 3 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[faern]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pinkisemils)

---

mullvad-cli/src/cmds/reset.rs, line 30 at r1 (raw file):

Previously, jvff (Janito Vaqueiro Ferreira Filho) wrote…

Minor: Maybe change the input hint so that it's something like [Yes/No (default)]?

Using y/N where the capital letter is the default is very standard.

---

mullvad-daemon/src/lib.rs, line 959 at r2 (raw file):

        }

        if let Err(e) = self.settings.reset() {

Don't we want this on_factory_reset to also notify all frontends that the settings changed?

self.event_listener.notify_settings(self.settings.clone());

[pinkisemils]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faern)

---

mullvad-daemon/src/lib.rs, line 959 at r2 (raw file):

Previously, faern (Linus Färnstrand) wrote…

Don't we want this on_factory_reset to also notify all frontends that the settings changed?

self.event_listener.notify_settings(self.settings.clone());

The daemon is supposed to restart at the end of this - so all listeners will have to resubscribe and reset anyway. But we can publish the new cleared settings, if you feel that will be more correct.