Improve downloading lyrics from LyricsWiki #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"edit" action is not limited to logged-in users. It's still possible to parse the original content without edit permissions though. The HTML element holding the lyrics also changed, and is now HTML-encoded.
|
@PeterNerlich this should fix the related error message you reported in #114. There was no lyrics for the song that created the error, but it should be handled (more) correctly now. Songs with lyrics should work (most of the time, this parsing is all a bit fragile...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"edit" action is not limited to logged-in users. It's still possible to
parse the original content without edit permissions though.
The HTML element holding the lyrics also changed, and is now HTML-encoded.