refactor(services): change parameters from complete state to uuid and…

… coordinates
multei · Jun 30, 2020 · 0960594 · 0960594
1 parent 2c6f5b8
commit 0960594
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 12 deletions.
diff --git a/src/services/__mocks__/parkings.js b/src/services/__mocks__/parkings.js
@@ -20,3 +20,9 @@ export const createParkingReport = (parkingReportState, version = 1) =>
     (resolve) => resolve(resolvedValue),
     (reject) => reject(rejectedValue)
   )
+
+export const completeParkingReport = (parkingReportState, version = 1) =>
+  new Promise(
+    (resolve) => resolve(resolvedValue),
+    (reject) => reject(rejectedValue)
+  )
diff --git a/src/services/parkings.js b/src/services/parkings.js
@@ -15,10 +15,10 @@ export const createParkingReport = (parkingReportState, version = 1) => {
   return Api().post(`/v${version}/parkings/`, formData)
 }
 
-export const completeParkingReport = (parkingReportState, version = 1) => {
+export const completeParkingReport = (uuid, coordinates, version = 1) => {
   const request = {
-    uuid: parkingReportState["uuid"],
-    coordinates: parkingReportState["currentPosition"],
+    uuid,
+    coordinates,
   }
 
   return Api().patch(`/v${version}/parkings/`, request)

diff --git a/src/services/parkings.test.js b/src/services/parkings.test.js
@@ -47,20 +47,15 @@ describe("Parkings API", () => {
 
   it("should call parkings API patch with the coordinates", () => {
     const uuid = "uuid"
-    const currentPosition = "-LAT,+LNG"
+    const coordinates = "-LAT,+LNG"
 
-    const parkingReportState = {
-      uuid,
-      currentPosition,
-    }
-
-    completeParkingReport(parkingReportState, version)
+    completeParkingReport(uuid, coordinates, version)
 
     expect(Api().patch).toHaveBeenCalledWith(
       `/v${version}/parkings/`,
       expect.objectContaining({
-        uuid: uuid,
-        coordinates: currentPosition,
+        uuid,
+        coordinates,
       })
     )
   })