eth,les,light,params: fix CHT handling for forked chains #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keying CHTs by genesis precludes the possibility of valid chain config between networks sharing genesis blocks.
tzdybal
suggested changes
Jun 9, 2019
eth/handler_test.go
Outdated
| @@ -506,8 +506,12 @@ func testCheckpointChallenge(t *testing.T, syncmode downloader.SyncMode, checkpo | |||
| var ( | |||
| db = rawdb.NewMemoryDatabase() | |||
| config = new(params.ChainConfig) | |||
| genesis = (&core.Genesis{Config: config}).MustCommit(db) | |||
| genesis *types.Block | |||
There was a problem hiding this comment.
We can remove genesis variable...
eth/handler_test.go
Outdated
| ) | ||
|
|
||
| genesis = (&core.Genesis{Config: config}).MustCommit(db) |
There was a problem hiding this comment.
... and simply ignore the return value from MustCommit, because it's actually what we're doing anyways.
tzdybal
approved these changes
Jun 10, 2019
meowsbits
added a commit
to meowsbits/multi-geth
that referenced
this pull request
Jan 28, 2020
cmd/echainspec,build: reimplement echainspec command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keying CHTs by genesis precludes the possibility of valid chain
config between networks sharing genesis blocks.