Add test for the created images. #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junaruga
force-pushed
the
feature/add-test
branch
2 times, most recently
from
a44d7ab
to
5083461
Compare
junaruga
changed the title
junaruga
changed the title
jeking3
approved these changes
Jun 10, 2019
The test is for only dnf case. The microdnf case is not prepared yet.
junaruga
force-pushed
the
feature/add-test
branch
from
3bff84b
to
2079351
Compare
|
@lafin could you review? I added a logic to test the created images. After this PR is merged, I am going to adapt it to other compatible images repositories. |
lafin
approved these changes
Jun 11, 2019
|
Guys, thanks for the review. Now it was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13 and multiarch/qemu-user-static#72 .
I think using
Makefileis natural in this project seeinghttps://github.com/multiarch/true/blob/master/Makefile .
Good news.
With QEMU v3.1.0-3, the s390x test are failed.
As Fedora 29 s390x is a full environment with
dnf, the test is executed and failed.As Fedora 30 s390x is a minimal environment without
dnfand withmicrodnf, the test is skipped. (So, succeeded)https://travis-ci.org/multiarch/fedora/builds/543888437
With QEMU 4.0.0-2, the Fedora 29 s390x is succeeded.
https://travis-ci.org/multiarch/fedora/builds/543893920
Adding the test, the Travis running time is increased. But I think that it's worth to add it.