Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsaddr code? #7

Closed
richardschneider opened this issue Mar 4, 2018 · 10 comments · Fixed by #8
Closed

dnsaddr code? #7

richardschneider opened this issue Mar 4, 2018 · 10 comments · Fixed by #8

Comments

@richardschneider
Copy link

richardschneider commented Mar 4, 2018

The code for dnsaddr is not consistent.

  • go uses code 12345
  • js uses code 53
  • protocols.csv does not mention dnsaddr but has a dns at code 53.

Can someone please clarify! cc: @diasdavid @whyrusleeping

richardschneider added a commit to richardschneider/net-ipfs-core that referenced this issue Mar 4, 2018
@whyrusleeping
Copy link
Member

Youre gonna have to ask @lgierth on that one. I don't know

@daviddias
Copy link
Member

AFAIU, @lgierth renamed dns to dnsaddr, which was 53 from early days -- https://github.com/multiformats/multiaddr/blob/master/protocols.csv#L7 --. @lgierth Any reason why you didn't update the multiaddr spec and protocol table https://github.com/multiformats/multiaddr ?

12345 looks like a "typed out random number" :)

@richardschneider
Copy link
Author

@lgierth any comment?

@ghost
Copy link

ghost commented Mar 23, 2018

Sorry - this was a really silly oversight from early development on this :/ Let's go with js's 53.

@richardschneider
Copy link
Author

Why dnsaddr and not just dns?

@ghost ghost mentioned this issue Mar 23, 2018
@ghost
Copy link

ghost commented Mar 23, 2018

Actually, let's keep 53 reserved for any future /dns protocol. I've filed multiformats/multiaddr#61, #8, and multiformats/js-multiaddr#59, and @ianopolous did multiformats/java-multiaddr@3a6d6548.

@richardschneider if that's cool with you do you wanna update net-ipfs-core too? (you referenced a commit up there)

Why dnsaddr and not just dns?

dnsaddr is the multiaddr-equivalent of dnslink -- we put multiaddrs into a DNS record, and /dnsaddr lets us resolve through them. This is used e.g. in go-ipfs's default bootstrap config. /dns on the other hand should be reserved for a "broader" dns address protocol, should there ever be the need for one in the future.

@ghost
Copy link

ghost commented Mar 23, 2018

I think this inconsistency is resolved once:

richardschneider added a commit to richardschneider/net-ipfs-core that referenced this issue Mar 23, 2018
@richardschneider
Copy link
Author

richardschneider commented Mar 23, 2018

@lgierth I changed the code in net-ipfs-core, you can now tick it!

@richardschneider
Copy link
Author

we put multiaddrs into a DNS record, and /dnsaddr lets us resolve through them.

I think I'm resolving dnsaddr incorrectly, see peer talk. Basically I'm accepting any A or AAAA resource record from DNS.

Could you detail or point me to a spec on how to resolve dnsaddr? Is this some magick/hackery with TXT records?

@ghost ghost closed this as completed in #8 Mar 23, 2018
@ghost ghost reopened this Mar 23, 2018
@ghost
Copy link

ghost commented Mar 23, 2018

Thanks @diasdavid -- all the impls can slowly roll this out with their next releases then.

@richardschneider There's unfortunately no proper spec, only the examples in the readme of this repo.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants