Add ipcidr support #177
Merged
Add ipcidr support #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 14, 2022
transcoders.go
Outdated
| @@ -54,6 +54,15 @@ func (t twrp) ValidateBytes(b []byte) error { | |||
| var TranscoderIP4 = NewTranscoderFromFunctions(ip4StB, ip4BtS, nil) | |||
| var TranscoderIP6 = NewTranscoderFromFunctions(ip6StB, ip6BtS, nil) | |||
| var TranscoderIP6Zone = NewTranscoderFromFunctions(ip6zoneStB, ip6zoneBtS, ip6zoneVal) | |||
| var TranscoderIPCIDR = NewTranscoderFromFunctions(func(s string) ([]byte, error) { | |||
There was a problem hiding this comment.
Looks like the convention here was to define separate functions.
There was a problem hiding this comment.
Do you know if there's a specific reason?
marten-seemann
approved these changes
Jun 17, 2022
|
@marten-seemann can you merge please? I don’t have access |
marten-seemann
approved these changes
Jun 19, 2022
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
ipcidrprotocol.Example:
/ip4/1.2.3.0/ipcidr/24Can be used by ipv6 as well