Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidy code generation, add KnownCodes, add Code.Tag method #59

Merged
merged 4 commits into from Dec 2, 2021
Merged

tidy code generation, add KnownCodes, add Code.Tag method #59

merged 4 commits into from Dec 2, 2021

Commits on Nov 23, 2021

  1. update submodule and re-generate 

    A few tags got changed; no noteworthy code changes.
    @mvdan
    mvdan committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    10132bd View commit details
    Browse the repository at this point in the history

  2. use "go run pkg@version" assuming Go 1.17 or later 

    Now that Go 1.17 came out four months ago,
we can clean up the go:generate comments.

We don't need to worry about supporting Go 1.16,
as "go generate" only needs to work for the few maintainers.

Fixes #41.
    @mvdan
    mvdan committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    05a0a1f View commit details
    Browse the repository at this point in the history

  3. add the KnownCodes API 

    Right now, this is simply backed by a code-generated slice,
but the API being a function gives us some wiggle room in the future.

The test simply ensures the list is reasonably sane;
that it has many codes, no unexpected duplicates,
and that a few known ones are present in it.

Updates #58.
    @mvdan
    mvdan committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    97796dd View commit details
    Browse the repository at this point in the history

  4. add Code.Tag method 

    Fixes #58.
    @mvdan
    mvdan committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    3a38134 View commit details
    Browse the repository at this point in the history