Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make go-generate workflow pull latest remote #73

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jan 30, 2023

No description provided.

@rvagg rvagg requested review from lidel and galargh January 30, 2023 01:55
Copy link
Contributor

@galargh galargh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind providing a little bit of context for the change? Why is the desired behaviour?

@rvagg
Copy link
Member Author

rvagg commented Jan 30, 2023

Because it's a cron job that's meant to check for changes to the multicodec table and open a PR here with the go generate changes when there are changes to the table. It's been running regularly but never opened a PR because it just fetches the submodule commit that's checked in here. By providing --remote we're asking it to fetch the latest HEAD commit and test that. We should get a PR after this is merged and run next because there's been quite a few changes.

@galargh galargh merged commit c731517 into master Jan 30, 2023
@galargh galargh deleted the rvagg/fix-gogen-action branch January 30, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants