-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for shake-128/256 #43
Conversation
.vscode/settings.json
Outdated
@@ -0,0 +1,3 @@ | |||
{ | |||
"vsicons.presets.angular": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidentally added this, mind removing? (can add to gitignore if you want)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove the vscode settings file, and then get these codes into the table at https://github.com/multiformats/multihash/blob/master/hashtable.csv
Thanks for all the work here :)
Oh whoops, i thought these codes were missing, but i see them now. Mind rebasing to fix the merge conflicts? |
4372004
to
540f149
Compare
github doesnt make this merging easy... It seems after each PR of yours that i merge, there are conflicts in all the others. If you want, you can go ahead and put them all in the same PR, with separate commits for each change |
Implemented support for Shake128/256
@whyrusleeping I've successfully rebased all my pr's now, hope you'll check them out soon :) |
No extra dependencies, as it's in the sha3 package. Closes #20