send fewer packets by combining writes when possible #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @marten-seemann. This was inspired by libp2p/go-libp2p#413. |
client.go
Outdated
| @@ -9,28 +10,52 @@ import ( | |||
| // the protocol specified for the handshake. | |||
| var ErrNotSupported = errors.New("protocol not supported") | |||
|
|
|||
| // ErrNoProtocols is the error returned when the no protocols have been | |||
| // specified. | |||
| var ErrNoProtocols = errors.New("protocol not supported") | |||
There was a problem hiding this comment.
This should be difficult from ErrNotSupported, otherwise ErrNotSupported == ErrNoProtocols.
There was a problem hiding this comment.
(I should try to not copy and paste...)
Kubuxu
force-pushed
the
feat/fewer-packets
branch
from
c6b2b30
to
32ee2f5
Compare
ghost
assigned 
vyzo
reviewed
May 17, 2019
| if len(protos) == 0 { | ||
| return "", ErrNoProtocols | ||
| } | ||
| switch err := SelectProtoOrFail(protos[0], rwc); err { |
There was a problem hiding this comment.
why isn't this part of the loop below?
There was a problem hiding this comment.
I'm combining the /multistream/1.0 handshake when negotiating the first protocol. I'll leave a comment.
There was a problem hiding this comment.
Done. This should drop us from two round trips to 1.
This makes the non-lazy negotiator act *slightly* more like the lazy one. Instead of sending the multistream header and *then* the protocol header, it sends them both in the same packet. This *shouldn't* cause any issues but we should still think carefully about whether or not this is worth it. It: 1. Sends fewer packets. 2. Saves half an RTT.
Stebalien
force-pushed
the
feat/fewer-packets
branch
from
32ee2f5
to
bfe6132
Compare
vyzo
approved these changes
May 17, 2019
This was referenced May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the non-lazy negotiator act slightly more like the lazy one.
Instead of sending the multistream header and then the protocol header, it
sends them both in the same packet.
This shouldn't cause any issues but we should still think carefully about
whether or not this is worth it. It: