fix: don't write from the read function #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing a double-write. fixes libp2p/go-libp2p-pnet#31 probably fixes ipfs/kubo#6802 fixes ipfs/kubo#6197
|
cc @bonedaddy |
|
After we merge this, we can revert libp2p/go-ws-transport#65. |
alanshaw
approved these changes
Feb 4, 2020
vyzo
reviewed
Feb 4, 2020
Comment on lines
-403
to
-406
| err := delimWriteBuffered(rw, []byte("messages over 64k are not allowed")) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
are we reporting this error anywhere now?
There was a problem hiding this comment.
Back to the user. We don't bother sending it to the other side. If someone establishes a connection and sends us garbage, we'll reset the connection and walk away.
Stebalien
added a commit
to libp2p/go-ws-transport
that referenced
this pull request
Feb 4, 2020
Actually fixed in multiformats/go-multistream#50 This reverts commit f6ca84a.
marten-seemann
pushed a commit
to libp2p/go-libp2p
that referenced
this pull request
Apr 22, 2022
Actually fixed in multiformats/go-multistream#50 This reverts commit 3d337a9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing a double-write.
fixes libp2p/go-libp2p-pnet#31
probably fixes ipfs/kubo#6802
fixes ipfs/kubo#6197