Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What is a valid HTTP multiaddr? #53

Closed
alanshaw opened this issue Feb 28, 2018 · 4 comments
Closed

What is a valid HTTP multiaddr? #53

alanshaw opened this issue Feb 28, 2018 · 4 comments

Comments

@alanshaw
Copy link
Member

According to https://multiformats.io/multiaddr/ I should be able to type something like /ip4/127.0.0.1/tcp/90/http/baz.jpg

...but this causes Error: no protocol with name: baz.jpg

See https://runkit.com/embed/q1wgjxqmnn38
@alanshaw alanshaw mentioned this issue Feb 28, 2018
Closed
@alanshaw
Copy link
Member Author

I'm guessing this is because I have an address + path...

@vmx
Copy link
Member

vmx commented Feb 28, 2018

The README also mentions /ip4/127.0.0.1/tcp/90/http/baz.jpg so I expect it to be a valid address.

@vmx vmx reopened this Feb 28, 2018
@vmx vmx mentioned this issue Feb 28, 2018
Closed
@vmx
Copy link
Member

vmx commented Feb 28, 2018

@diasdavid As you are the captain, can you please confirm?

@daviddias
Copy link
Member

@vmx the README was added on #14 and apparently I missed that baz.jpg was added, that shouldn't be there. Good catch!

@victorb victorb mentioned this issue Apr 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vmx @alanshaw @daviddias