fix: leverage pkg.exports #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First of all: the `pkg.exports` spec defines that object key order is being used when resolving for the targeted environment, see uuidjs/uuid#462 (comment) In order for `webpack@5` to pick up the `browser` overrides they must come _before_ `import` and `require`, see https://gist.github.com/sokra/e032a0f17c1721c71cfced6f14516c62 for preliminary documentation. To make full use of `pkg.exports` in node as well we can use package self reference instead of local paths, see the discussion in jkrems/proposal-pkg-exports#47 Unfortunately the browser testing tool polendina doesn't play nice with self reference since it only looks for bare module specifiers in `node_modules` and `node_modules/polendina/node_modules`, see https://github.com/rvagg/polendina/blob/master/lib/webpack.config.js#L28-L39 We would need a way to set up an `resolve.alias` for webpack in polendina to make package self reference work.
ctavan
force-pushed
the
use-self-reference-to-leverage-package-exports
branch
from
595cd46
to
ecc4541
Compare
|
I'm so sorry, this somehow slipped under my notifications and I never saw it. This looks great, I'll clean up the merge conflicts and get it in today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all: the
pkg.exportsspec defines that object key order isbeing used when resolving for the targeted environment, see
uuidjs/uuid#462 (comment)
In order for
webpack@5to pick up thebrowseroverrides they mustcome before
importandrequire, seehttps://gist.github.com/sokra/e032a0f17c1721c71cfced6f14516c62 for
preliminary documentation.
To make full use of
pkg.exportsin node as well we can use packageself reference instead of local paths, see the discussion in
jkrems/proposal-pkg-exports#47
Unfortunately the browser testing tool polendina doesn't play nice with
self reference since it only looks for bare module specifiers in
node_modulesandnode_modules/polendina/node_modules, seehttps://github.com/rvagg/polendina/blob/master/lib/webpack.config.js#L28-L39
We would need a way to set up anresolve.aliasfor webpack inpolendina to make package self reference work.
Edit: Polendina issue fixed through rvagg/polendina#8 (comment)