This repository has been archived by the owner on Oct 19, 2022. It is now read-only.
[WIP] pull-streams #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 8, 2016
28 tasks
| @@ -2,7 +2,7 @@ | |||
| "name": "multistream-select", | |||
| "version": "0.10.0", | |||
| "description": "JavaScript implementation of the multistream spec", | |||
| "main": "lib/index.js", | |||
| "main": "src/index.js", | |||
|
Always impressive to see how pull-streams make everything more elegant and smaller |
| handlersMap[key](new Connection(shake.rest(), rawConn)) | ||
| } else { | ||
| log('unkown protocol: %s', protocol) | ||
| defaultHandler(protocol, shake.rest()) |
There was a problem hiding this comment.
See above, it's a function passed in, allowing to add special handling of non existent protocols.
There was a problem hiding this comment.
That is not part of the spec. If the protocol doesn't exist, na is returned.
|
Last things to do before merge:
Good to have:
|
| expect( | ||
| data | ||
| ).to.be.eql( | ||
| ['banana'] |
daviddias
force-pushed
the
pull
branch
2 times, most recently
from
b89374e
to
89e5f07
Compare
- add test to verify that both dialer and listener send multistream handshake right away - fix structure and func naming - not wait on listener - support multiple selects
|
Node.js 4 and 5 don't like: |
unnsupported feature
|
another one bites the dust! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are passing but needs clean up and integration verification