Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial process upgrades for Multiformats registry group and org #65
Initial process upgrades for Multiformats registry group and org #65
Changes from 25 commits
bf8c973
77007bb
5a365ef
5eab8d0
6a703d7
924721b
fc4f4e8
8b00470
9e53696
05887e9
f322d3e
ff1f407
6c19228
1ab4da9
2ea1271
87d1427
0d5ccdc
f8b38ef
f37b62e
dab4d59
f75eb98
e4064af
40bff07
edecea2
4644edd
8e6d769
9bd83ec
963024d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
multistream-select might still be a thing, so it might make sense to keep it here. @marten-seemann or @mxinden might know more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the ping. I suggest not standardizing multistream-select. I think it is very libp2p specific. If one would want to standardize a protocol negotiation protocol, I suggest starting from scratch similar to libp2p/specs#349.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: I didn't know that. I usually capitalize Multiformats in any case as I treat it as a proper noun. But that might only be me. I'd just remove that sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This note dates back to 2016 according to github "blame"/commit-tracing view. I don't mind either way if we remove it or keep it but I have noticed it was at least internally consistent in the other readmes in this org?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rvagg any thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't care enough to have an opinion, I'm more triggered by using ` two sentences up around the words, but not enough to object either