-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to multihash 0.19 #140
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,15 +11,16 @@ edition = "2021" | |
rust-version = "1.60" | ||
|
||
[features] | ||
default = ["std", "multihash/default"] | ||
std = ["multihash/std", "unsigned-varint/std", "alloc", "multibase/std", "serde/std"] | ||
default = ["std", "multihash/default", "multihash-codetable/default"] | ||
std = ["multihash/std", "multihash-codetable/std", "unsigned-varint/std", "alloc", "multibase/std", "serde/std"] | ||
alloc = ["multibase", "multihash/alloc", "core2/alloc", "serde/alloc"] | ||
arb = ["quickcheck", "rand", "multihash/arb", "multihash/multihash-impl", "multihash/sha2", "arbitrary"] | ||
arb = ["quickcheck", "rand", "multihash/arb", "arbitrary"] | ||
scale-codec = ["parity-scale-codec", "multihash/scale-codec"] | ||
serde-codec = ["alloc", "serde", "multihash/serde-codec", "serde_bytes"] | ||
|
||
[dependencies] | ||
multihash = { version = "0.18.0", default-features = false } | ||
multihash = { version = "0.19.0", default-features = false } | ||
multihash-codetable = { version = "0.1.0", default-features = false, features = ["digest", "sha2"] } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. With the upgrade to of Multihash, we should take the chance of reducing the dependency tree. From this PR, it looks like I know it's a breaking change, but the code table was only re-exported as the full library was. With separate crates we now have more flexibility here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Happy to :) |
||
unsigned-varint = { version = "0.7.0", default-features = false } | ||
|
||
multibase = { version = "0.9.1", optional = true, default-features = false } | ||
|
@@ -33,5 +34,5 @@ arbitrary = { version = "1.1.0", optional = true } | |
core2 = { version = "0.4", default-features = false } | ||
|
||
[dev-dependencies] | ||
multihash-derive = { version = "0.9.0", default-features = false } | ||
serde_json = "1.0.59" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will add
multihash-codetable
by default. So just remove them from here.I needed to check that myself and figured out that it's the same for the other optional dependencies as well. I guess we should fix that properly somehow. But for now at least not adding
multihash-codetable
is a good first step.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yep. The solution is
?/
, which only sets it if present.