General rework of the library #28
Conversation
|
This PR is an upstream of the local changes we've been making as part of https://github.com/libp2p/rust-libp2p/tree/master/rust-multiaddr All these changes have already been reviewed. If nobody expresses opposition, I will merge in a few days. |
src/protocol.rs
Outdated
|
|
||
| use {Result, Error}; | ||
|
|
||
| ///! # Protocol | ||
| ///! # ProtocolId |
There was a problem hiding this comment.
Do you mean this comment in particular, or the whole enum?
There was a problem hiding this comment.
That's subjective, but I think ProtocolId makes it clearer it is not a whole protocol definition for example.
I admit that in practice it's because in my first draft AddrComponent was named Protocol.
If you don't like it, I will change it back. I don't have a strong opinion.
There was a problem hiding this comment.
lets use Protocol as it better matches what the go library is doing: https://github.com/multiformats/go-multiaddr/blob/master/protocols.go
Based over #27
Right now if you want to examine the content of the
Multiaddr, you have to callas_bytes()and examine bytes one by one and making the assumptions that they are going to be in a certain format.This PR does many minor changes to the library, and most notably adds the
AddrComponenttype which represents one segment of a multiaddr in a strongly-typed fashion. The components can be enumerated withMultiaddr::iter(). Because of this large change, parsing has also been reworked.