Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example in readme #46

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Fix example in readme #46

merged 2 commits into from
Jun 22, 2021

Conversation

kpp
Copy link
Contributor

@kpp kpp commented Jun 22, 2021 •
edited

There is no ToMultiaddr in the crate so the example in README does not compile. I fixed it and added an example of macro multiaddr!.

mxinden
mxinden approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks @kpp. Very much appreciated.

README.md Outdated Show resolved Hide resolved
@kpp @mxinden
Update README.md
3e54dd2 
Co-authored-by: Max Inden <mail@max-inden.de>
@mxinden mxinden merged commit 95d5e64 into multiformats:master Jun 22, 2021
@kpp kpp deleted the patch-1 branch June 22, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kpp @mxinden