Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: Prepare v0.16.0 #62

Merged
merged 4 commits into from
Nov 13, 2022
Merged

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Nov 4, 2022

Unlocks libp2p/rust-libp2p#2982.

Any objections by anyone? Anything else you would like to see included?

@mxinden
Copy link
Member Author

mxinden commented Nov 4, 2022

//CC @John-LittleBearLabs

@mxinden
Copy link
Member Author

mxinden commented Nov 8, 2022

Friendly ping @dignifiedquire as the Captain of the project.

On a related note, I am happy to officially co-maintain this project @dignifiedquire if you would like help.

@elenaf9
Copy link
Contributor

elenaf9 commented Nov 8, 2022

If this is not super urgent I'd like to include the changes proposed in multiformats/multiaddr#147, for which I will do a PR on rust-multiaddr in the next days. Since libp2p/rust-libp2p#2289 is blocked on it I'd like to have it included in this release.

@mxinden
Copy link
Member Author

mxinden commented Nov 8, 2022

If this is not super urgent I'd like to include the changes proposed in multiformats/multiaddr#147, for which I will do a PR on rust-multiaddr in the next days. Since libp2p/rust-libp2p#2289 is blocked on it I'd like to have it included in this release.

I suggest we don't block on your upcoming pull request to add /quic-v1 here. In case it makes it in time, great. In case it doesn't, I am happy to cut another release right after your upcoming pull request has been merged.

@marten-seemann
Copy link

If this is not super urgent I'd like to include the changes proposed in multiformats/multiaddr#147, for which I will do a PR on rust-multiaddr in the next days. Since libp2p/rust-libp2p#2289 is blocked on it I'd like to have it included in this release.

I suggest we don't block on your upcoming pull request to add /quic-v1 here. In case it makes it in time, great. In case it doesn't, I am happy to cut another release right after your upcoming pull request has been merged.

It would be a very sad state of affairs if the existing QUIC code point was used for nodes that only speak QUIC v1. Currently, we have the property that every node that advertises the existing code point speaks QUIC draft-29 (and potentially QUIC v1 in addition).

@marten-seemann
Copy link

Not sure if I was commenting on the right issue, or if my comment even makes sense in this repo ;)

I just meant to caution against rolling out rust-libp2p with QUIC support using the existing code point, given that we seem to be converging on minting a new code point for QUIC v1.

@mxinden
Copy link
Member Author

mxinden commented Nov 10, 2022

Not sure if I was commenting on the right issue, or if my comment even makes sense in this repo ;)

This release only releases #60.

Whether to block libp2p/rust-libp2p#2289 on multiformats/multiaddr#147 is orthogonal to this release.

Your comment is important @marten-seemann. I suggest to move it to libp2p/rust-libp2p#2289 or multiformats/multiaddr#147

@mxinden mxinden merged commit 011b814 into multiformats:master Nov 13, 2022
@mxinden
Copy link
Member Author

mxinden commented Nov 13, 2022

Tagged and published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants