fix: don't depend on unnecessary multihash features
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
commented
Feb 27, 2023
4 tasks
mxinden
reviewed
Mar 2, 2023
thomaseizinger
requested review from
vmx and
mxinden
and removed request for
vmx
mxinden
approved these changes
Mar 17, 2023
mxinden
changed the title
multihash featuresmultihash features
|
@thomaseizinger do you have some time to look at the "Build" CI failures? I am taking a look at the code coverage failures now. |
Maybe later tonight yes, otherwise likely only next week. |
|
@vmx Can you change the repository settings as per https://matklad.github.io/2022/10/24/actions-permissions.html? The workflows don't run at the moment. |
Done |
mergify bot
pushed a commit
to libp2p/rust-libp2p
that referenced
this pull request
Mar 30, 2023
All we need from the multihash is for it to be a data structure that we pass around. We only ever use the identity "hasher" and the sha256 hasher. Those are easily implemented without depending the (fairly heavy) machinery in `multihash`. Unfortunately, this patch by itself does not yet lighten our dependency tree because `multiaddr` activates those features unconditionally. I opened a companion PR for this: multiformats/rust-multiaddr#77. multiformats/rust-multiaddr#77 is another breaking change and we are trying to delay those at the moment. However, it will (hopefully) land eventually which should then be much easier to implement. Fixes #3276. Pull-Request: #3514.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these features activated,
multihashis quite heavy. Whilst we are in the process of fixing this, removing these features is a first good step towards that.I think technically, this is a breaking change unfortunately because we re-export all of
multihashand thus someone could have relied on the presence ofmultihash::Codethrough the re-export ofmultihash.