fix: Rename Protocol::WebRTC string rep /webrtc to /webrtc-direct
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Considered non-breaking change as `/webrtc` will still be parsed to `Protocol::WebRTC` and no known production deployment of `libp2p-webrtc` known. See multiformats/multiaddr#150 (comment) for context.
thomaseizinger
approved these changes
Mar 22, 2023
CHANGELOG.md
Outdated
|
|
||
| - Rename string representation of `WebRTC` protocol from `/webrtc` to `/webrt-direct`. | ||
| For backwards compatibility `/webrtc` will still be decoded to `Protocol::WebRTC`, but `Protocol::WebRTC` will from now on always be encoded as `/webrtc-direct`. | ||
| See [multiformats/multiaddr discussion] for context. |
src/protocol.rs
Outdated
| @@ -200,6 +200,7 @@ impl<'a> Protocol<'a> { | |||
| "p2p-websocket-star" => Ok(Protocol::P2pWebSocketStar), | |||
| "p2p-webrtc-star" => Ok(Protocol::P2pWebRtcStar), | |||
| "webrtc" => Ok(Protocol::WebRTC), | |||
There was a problem hiding this comment.
Can we emit a log here that this variant is deprecated?
3 tasks
mxinden
added a commit
to mxinden/rust-multiaddr
that referenced
this pull request
Mar 23, 2023
…t` (multiformats#84) Considered non-breaking change as `/webrtc` will still be parsed to `Protocol::WebRTC` and no known production deployment of `libp2p-webrtc` known. See multiformats/multiaddr#150 (comment) for context.
mxinden
added a commit
that referenced
this pull request
Mar 23, 2023
…t` (#84) (#87) Considered non-breaking change as `/webrtc` will still be parsed to `Protocol::WebRTC` and no known production deployment of `libp2p-webrtc` known. See multiformats/multiaddr#150 (comment) for context.
melekes
added a commit
to melekes/substrate
that referenced
this pull request
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considered non-breaking change as
/webrtcwill still be parsed toProtocol::WebRTCand no known production deployment oflibp2p-webrtcknown.See multiformats/multiaddr#150 (comment) for context.
@melekes @thomaseizinger can you take a look?