[wip] next version #30
Conversation
ghost
assigned 
src/digests.rs
Outdated
|
|
||
| #[Size = "32"] | ||
| #[Digest = "sha2::Sha256"] | ||
| Sha2256 = 0x12, |
There was a problem hiding this comment.
Does it really have to be like that?
There was a problem hiding this comment.
I mean the Sha2256. I understand need for no _ but something like Sha256V2, Sha256V3, Sha512V2. Anything to make it valid syntactically.
There was a problem hiding this comment.
@dignifiedquire however you feel, anyway, just an observation.
There was a problem hiding this comment.
Can we get it to be SHA2_256 etc.?
| @@ -0,0 +1,229 @@ | |||
| #![recursion_limit = "1024"] | |||
There was a problem hiding this comment.
tldr: it doesn't compile when I remove it
longer form:
as far as I understand the reason is that we are using macros, e.g. quote! inside the definition of another macro, and there is a recursion thing that breaks from the parsing level, but I am not entirely sure and haven't found any good docs on this yet
There was a problem hiding this comment.
this the best thing I found so far:
Recursion limit
The quote! macro relies on deep recursion so some large invocations may fail with "recursion limit reached" when you compile. If it fails, bump up the recursion limit by adding #![recursion_limit = "128"] to your crate. An even higher limit may be necessary for especially large invocations. You don't need this unless the compiler tells you that you need it.
| } | ||
|
|
||
| let code = | ||
| fetch_discriminant(&variant.discriminant).expect("Please provide the code as discriminant"); |
|
For what it's worth, we have a fork in the rust-libp2p repo that also contains a lot of changes: https://github.com/libp2p/rust-libp2p/tree/master/misc/multihash (We did that in order to not have to wait for a review every time we needed something) |
|
@tomaka thanks for reminding me, I would like to make sure to get all things that are important for you back into here. I‘ll review the commits there, but is there anything specific you have as a requirement you want to point out? |
|
it would also be great to get feedback if this branch is in a state that you could base your work on in rust-libp2p or if not what is missing. |
|
interesting would be to add a cli app to compute hashes from stdin. would be useful to be able to do something like this: |
|
So is this getting merged? |
|
Is this library still being maintained? SHA2 is already on a version 0.8.1; this PR also removes dependency on 0.7.x version of SHA2... |
|
Yeah it's still being maintained, just currently busy with other things. |
|
I'm closing this PR as most of the features got implemented one way or another with the release of 0.10.0. Missing is the |
stdfeature, and test forno_stdcompat (needs verification)asmandsimdfeatures to allow enabling those on the underlying hashersMultihashwrapper type around the actual hash