Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lineupJS as our attribute visualization #242

Merged
merged 22 commits into from
Jun 2, 2021
Merged

Add lineupJS as our attribute visualization #242

merged 22 commits into from
Jun 2, 2021

Conversation

JackWilb
Copy link
Member

@JackWilb JackWilb commented Apr 29, 2021

Add lineupJS as our node attribute visualization

To resolve the compilation errors with lineup, I had to skipLibCheck in the tsconfig. This means that we no longer type check the imported libs, reducing our type safety slightly. See #258

TODO:

@JackWilb JackWilb changed the title [WIP] Add linupeJS as our attribute visualization [WIP] Add linupJS as our attribute visualization Apr 29, 2021
@JackWilb JackWilb changed the title [WIP] Add linupJS as our attribute visualization [WIP] Add lineupJS as our attribute visualization May 4, 2021
@JackWilb JackWilb marked this pull request as ready for review June 2, 2021 20:57
@JackWilb JackWilb requested a review from gotdairyya June 2, 2021 20:57
gotdairyya
gotdairyya previously approved these changes Jun 2, 2021
Copy link
Contributor

@gotdairyya gotdairyya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a few issues with some of the bugs that I could catch. Other than that, it is running locally and looks good!

@JackWilb JackWilb changed the title [WIP] Add lineupJS as our attribute visualization Add lineupJS as our attribute visualization Jun 2, 2021
@JackWilb JackWilb merged commit 90d21e2 into master Jun 2, 2021
@JackWilb JackWilb deleted the lineup branch June 2, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants