Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple small issues with lineup #396

Merged
merged 13 commits into from
Jun 21, 2022
Merged

Fix multiple small issues with lineup #396

merged 13 commits into from
Jun 21, 2022

Conversation

JackWilb
Copy link
Member

@JackWilb JackWilb commented Jun 3, 2022

Does this PR close any open issues?

Depends on #393
Closes #261
Closes #262
Closes #384

Give a longer description of what this PR addresses and why it's needed

Fixes a ton of small issues that have been affecting the lineup vis

Provide pictures/videos of the behavior before and after these changes (optional)

For #262:
image

Are there any additional TODOs before this PR is ready to go?

TODOs:

@netlify
Copy link

netlify bot commented Jun 3, 2022

Deploy Preview for multimatrix ready!

Name Link
🔨 Latest commit 62b9a96
🔍 Latest deploy log https://app.netlify.com/sites/multimatrix/deploys/62b1f2992d1d120009bffd48
😎 Deploy Preview https://deploy-preview-396--multimatrix.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JackWilb JackWilb marked this pull request as ready for review June 16, 2022 17:09
@JackWilb JackWilb requested a review from gotdairyya June 16, 2022 17:09
Copy link
Contributor

@gotdairyya gotdairyya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a few bugs:

image

  • The menu for Lineup is cutoff (fixed with minimum height. Can be scrolled)

image

@JackWilb
Copy link
Member Author

I've edited the above comment to link the the new issues that I've created for them

@JackWilb JackWilb changed the title Lineup fixes Fix multiple small issues with lineup Jun 21, 2022
@JackWilb JackWilb merged commit bc7347c into main Jun 21, 2022
@JackWilb JackWilb deleted the lineup-fixes branch June 21, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants