-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple small issues with lineup #396
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for multimatrix ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
gotdairyya
requested changes
Jun 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a few bugs:
- When you filter with LineUp the matrix doesn't filter (When you filter with LineUp the matrix doesn't filter #400)
- The menu for Lineup is cutoff (fixed with minimum height. Can be scrolled)
- If a sort order in LineUp is selected, clicking the sort order in the matrix should override it (currently it does not) (If a sort order in LineUp is selected, clicking the sort order in the matrix should override it #401)
- If the matrix is aggregated, Lineup should preserve the parent-child groupings (currently it does not) ( If the matrix is aggregated, Lineup should preserve the parent-child groupings #402)
I've edited the above comment to link the the new issues that I've created for them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Depends on #393
Closes #261
Closes #262
Closes #384
Give a longer description of what this PR addresses and why it's needed
Fixes a ton of small issues that have been affecting the lineup vis
Provide pictures/videos of the behavior before and after these changes (optional)
For #262:
![image](https://user-images.githubusercontent.com/36867477/171963362-bdaacafb-5ffe-4650-ab56-924799f7a0e5.png)
Are there any additional TODOs before this PR is ready to go?
TODOs: