Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data upload improvements #295

Merged
merged 14 commits into from
Aug 4, 2023
Merged

Data upload improvements #295

merged 14 commits into from
Aug 4, 2023

Conversation

JackWilb
Copy link
Member

@JackWilb JackWilb commented Jul 27, 2023

Does this PR close any open issues?

Closes #289
Closes #220
Closes #158
Closes #143
Closes #142
Closes #93
Closes #61
Closes #55
Closes #38
Closes #35
Closes #25
Closes #14

Give a longer description of what this PR addresses and why it's needed

This PR combines the data upload and network creation into one flow. The idea behind this is to simplify the process of getting data into multinet and massaging it into networks. So far, the upload is working pretty well, but there are a couple of TODOs (tracked below) for the uploader and for the network creation tool. This simplification has resulted in the ability to upload types for all json formatted files, and a more cohesive feel.

Provide pictures/videos of the behavior before and after these changes (optional)

Are there any additional TODOs before this PR is ready to go?

TODOs:

@netlify
Copy link

netlify bot commented Jul 27, 2023

Deploy Preview for multinet-client ready!

Name Link
🔨 Latest commit f917a2f
🔍 Latest deploy log https://app.netlify.com/sites/multinet-client/deploys/64cd846cb2ba1f0008a1da64
😎 Deploy Preview https://deploy-preview-295--multinet-client.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JackWilb JackWilb marked this pull request as ready for review August 4, 2023 19:21
@JackWilb JackWilb merged commit ad3f554 into main Aug 4, 2023
6 checks passed
@JackWilb JackWilb deleted the uploader-improvements branch August 4, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment