Skip to content
This repository has been archived by the owner on Feb 23, 2022. It is now read-only.

Graph improvements #255

Merged
merged 20 commits into from
Mar 4, 2020
Merged

Graph improvements #255

merged 20 commits into from
Mar 4, 2020

Conversation

jtomeck
Copy link
Collaborator

@jtomeck jtomeck commented Jan 13, 2020

@waxlamp

I've set up the new layout to allow for the visualization area. Here are some things that will be needed:

  • Figure out columns in the "Nodes List" so that no scrolling is required and that only pagination is needed.
  • Allow for hiding the "bottom tray" with the small arrow icon. (this could be javascript onClick that sets the height of .node-cols to 13px and the height of .graph-viz to calc(100vh - 76px) and switching the arrow to an up arrow. Then resetting if you click it again. I'm just not sure how to handle all of that.
  • And finally, adding the viz.

I know we talked about having tabs in the "ways to visualize" sidebar for external apps and internal viz modes. I say we cross that bridge when we get there.

Let me know what you think!

@jtomeck jtomeck added the ui label Jan 13, 2020
@jtomeck jtomeck requested a review from waxlamp January 13, 2020 21:40
@jtomeck
Copy link
Collaborator Author

jtomeck commented Jan 13, 2020

@waxlamp @AlmightyYakob

One more thing. I pulled back from using vuetify's grid and just settled on using their helper classes for flex items to make this layout. Jake mentioned he might want to spend some time figuring out how to do it using the vuetify grid.

@waxlamp
Copy link
Collaborator

waxlamp commented Jan 14, 2020

@waxlamp @AlmightyYakob

One more thing. I pulled back from using vuetify's grid and just settled on using their helper classes for flex items to make this layout. Jake mentioned he might want to spend some time figuring out how to do it using the vuetify grid.

@AlmightyYakob, feel free to spend a few hours looking into Vuetify grid issues.

@waxlamp
Copy link
Collaborator

waxlamp commented Jan 14, 2020

@waxlamp

I've set up the new layout to allow for the visualization area. Here are some things that will be needed:

  • Figure out columns in the "Nodes List" so that no scrolling is required and that only pagination is needed.

Do you have a general strategy in mind for this? If it's a matter of recomputing "columns" by re-ordering the "rows" of data, I can probably help with that bit.

  • Allow for hiding the "bottom tray" with the small arrow icon. (this could be javascript onClick that sets the height of .node-cols to 13px and the height of .graph-viz to calc(100vh - 76px) and switching the arrow to an up arrow. Then resetting if you click it again. I'm just not sure how to handle all of that.

I assume we can do this with a method in the component that toggles the tray by doing something like this. I will try to add a simple version that demonstrates the idea, and then we can worry about things like animation, etc., later. Sound good?

  • And finally, adding the viz.

This part is a bit of a juggling act, so I will probably work up a simple "vis" component that simply displays some information about the graph as a stand-in or as a default option before the user selects a real vis to show in its place.

I know we talked about having tabs in the "ways to visualize" sidebar for external apps and internal viz modes. I say we cross that bridge when we get there.

Agreed. Even tabs may not be the right idea, but perhaps a dropdown instead. As you say, let's worry about that later.

Let me know what you think!

Overall I think it looks great! We'll have to play around some more to really figure it out. Thanks for working on this!

@jtomeck jtomeck marked this pull request as ready for review January 29, 2020 15:28
@jtomeck
Copy link
Collaborator Author

jtomeck commented Jan 29, 2020

Do you have a general strategy in mind for this? If it's a matter of recomputing "columns" by re-ordering the "rows" of data, I can probably help with that bit.

That is the strategy I had planned, I just wasn't sure how to implement it. Your help would be great!

Agreed. Even tabs may not be the right idea, but perhaps a dropdown instead. As you say, let's worry about that later.

I added a sample select to the sidebar. What do you think we should label it? @waxlamp

@@ -378,7 +378,7 @@ ul {
.edge-type-list,
.node-list {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.node-list will be able to be removed once we implement columns for the nodes column.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a general strategy in mind for this? If it's a matter of recomputing "columns" by re-ordering the "rows" of data, I can probably help with that bit.

That is the strategy I had planned, I just wasn't sure how to implement it. Your help would be great!

Ok I'll come and talk to you about the problem and then figure out how I can help.

Agreed. Even tabs may not be the right idea, but perhaps a dropdown instead. As you say, let's worry about that later.

I added a sample select to the sidebar. What do you think we should label it? @waxlamp

"Visualization".

It's sort of in the wrong spot though--right now it's under the "more ways to visualize" heading, which lumps it in with the "external" vis links that are supposed to be there.

(Apologies. I have a petty and abiding hatred of the "viz" variant.)
@waxlamp
Copy link
Collaborator

waxlamp commented Jan 29, 2020

  • Allow for hiding the "bottom tray" with the small arrow icon. (this could be javascript onClick that sets the height of .node-cols to 13px and the height of .graph-viz to calc(100vh - 76px) and switching the arrow to an up arrow. Then resetting if you click it again. I'm just not sure how to handle all of that.

I added logic to handle this in 30e7bcf but:

  • There's no animation. Not really convinced there needs to be.
  • It doesn't seem to actually "hide" the drawer, it just shoves it below the visible part of the page (and causes a scrollbar to show up). Not sure if the height: 100% needs to change to height: 0px or something.

@waxlamp
Copy link
Collaborator

waxlamp commented Jan 29, 2020

Not a big fan of the transition--feels too slow (and is sort of choppy, at least on my computer). If it were faster (100-200ms) then maybe, but I also think if it snaps open/shut instantaneously that's actually a pretty good interaction.

The scrollbar appearing when the panel is closed still seems to be a problem.

@jtomeck
Copy link
Collaborator Author

jtomeck commented Feb 3, 2020

The scrollbar appearing when the panel is closed still seems to be a problem.

@waxlamp can you give me a screenshot where this is happening? Mac doesn't show scrollbars until you actually scroll.

@jtomeck
Copy link
Collaborator Author

jtomeck commented Feb 4, 2020

@waxlamp nevermind I figured it out. Let me know if this transition speed works for you or if it's still choppy. It seems fine to me, but if there's a chance of it working poorly on everyone else's machine, we can just remove the transition.

@waxlamp
Copy link
Collaborator

waxlamp commented Feb 4, 2020

@waxlamp nevermind I figured it out. Let me know if this transition speed works for you or if it's still choppy. It seems fine to me, but if there's a chance of it working poorly on everyone else's machine, we can just remove the transition.

The transition still feels choppy, but I'm also still getting the scrollbar issue, so maybe it's easier for me to show you in person.

@waxlamp
Copy link
Collaborator

waxlamp commented Feb 13, 2020

The transitionless drawer looks/feels great.

@waxlamp
Copy link
Collaborator

waxlamp commented Feb 14, 2020

Just FYI, the ball is now in my court to create something to go into the "VISUALIZATION GOES HERE" slot.

waxlamp
waxlamp previously approved these changes Mar 4, 2020
Copy link
Collaborator

@waxlamp waxlamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not perfect but I think it looks great and we can easily build off of this. Thanks for the hard work @jtomeck and @AlmightyYakob!

@jtomeck
Copy link
Collaborator Author

jtomeck commented Mar 4, 2020

@waxlamp @AlmightyYakob - We should probably hide the dropdown that says "foo" and "bar" in it for now before merging.

@jjnesbitt jjnesbitt merged commit 771b218 into master Mar 4, 2020
@jjnesbitt jjnesbitt deleted the graph-improvements branch March 4, 2020 18:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants