mptcp: add FastOpen sender tests #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matttbe
force-pushed
the
mptcp-fastopen-client
branch
from
ce7350c
to
f75dc1c
Compare
For the moment, only the client part is validated. 2 methods are currently tested: - TCP_FASTOPEN_CONNECT - MSG_FASTOPEN For each method, there are two tests: - one without using TFO cookies - one where a first connection is created to validate the cookie part. Then a second connection is established with data in the SYN. Note that it looks like Packetdrill doesn't support creating a 2nd connection on the same script yet. When we do that, Packetdrill reports the 3rd ACK of the 2nd connection doesn't contain the expected the client key. But that's alright for the moment, tests have been split: with and without cookies. These tests can be used to validate Benjamin' series: mptcp: add support for TFO, sender side only. In the v2, MSG_FASTOPEN support has been removed as it is part of Dmytro's series. Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
matttbe
force-pushed
the
mptcp-fastopen-client
branch
from
f75dc1c
to
f3672b8
Compare
Similar to the one for TCP in tcp/syscall_bad_arg dir. Differences: - create IPPROTO_MPTCP sockets instead of TCP ones - With a tolerance - Keep the TS - Swtich to the same code style as other MPTCP tests But the rest is the same, validating the same thing but for MPTCP. Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
matttbe
force-pushed
the
mptcp-fastopen-client
branch
from
af86f4d
to
585b416
Compare
|
I hope you don't mind, I'm going to merge this to validate patches I'm going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the moment, only the client part is validated.
2 methods are currently tested:
TCP_FASTOPEN_CONNECTMSG_FASTOPENFor each method, there are two tests:
Note that it looks like Packetdrill doesn't support creating a 2nd connection on the same script yet. When we do that, Packetdrill reports the 3rd ACK of the 2nd connection doesn't contain the expected the client key. But that's alright for the moment, tests have been split: with and without cookies.
These tests can be used to validate Benjamin' series:
mptcp: add support for TFO, sender side only. In the v2,MSG_FASTOPENsupport has been removed as it is part of Dmytro's series.