Elasticsearch scroll fixes (#242)

* Elasticsearch scroll fixes * More ui fixes * Add back tests
multiprocessio · May 10, 2022 · bf0aad0 · bf0aad0
1 parent ebacfaa
commit bf0aad0
Show file tree

Hide file tree

Showing 4 changed files with 214 additions and 159 deletions.
diff --git a/.github/workflows/pull_requests.yml b/.github/workflows/pull_requests.yml
@@ -5,135 +5,135 @@ on:
     branches: [main]
 
 jobs:
-  # test:
-  #   runs-on: ubuntu-latest
-
-  #   steps:
-  #   - uses: actions/checkout@master
-  #     with:
-  #       ref: ${{ github.ref }}
-
-  #   # FROM: https://github.com/actions/cache/blob/main/examples.md#node---yarn
-  #   - name: Get yarn cache directory path
-  #     id: yarn-cache-dir-path
-  #     run: echo "::set-output name=dir::$(yarn cache dir)"
-
-  #   - uses: actions/cache@v2
-  #     id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
-  #     with:
-  #       path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
-  #       key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
-  #       restore-keys: |
-  #         ${{ runner.os }}-yarn-
-  #   - run: ./scripts/ci/prepare_linux.sh --integration-tests
-  #   - run: yarn format
-  #   - run: yarn eslint ui
-  #   - run: yarn tsc
-  #   - run: cd runner && gofmt -w .
-  #   - run: yarn build-language-definitions
-  #   - run: ./scripts/fail_on_diff.sh
-  #   - run: yarn test-licenses
-  #   # Needed so we can have ./build/desktop_runner.js and ./build/go_desktop_runner ready for tests
-  #   - run: yarn build-test-runner
-  #   - run: yarn test --detectOpenHandles --forceExit --verbose
-  #     env:
-  #       AIRTABLE_TOKEN: ${{ secrets.AIRTABLE_TOKEN }}
-  #       AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
-  #       AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-  #       BIGQUERY_TOKEN: ${{ secrets.BIGQUERY_TOKEN }}
-  #       SNOWFLAKE_USER: ${{ secrets.SNOWFLAKE_USER }}
-  #       SNOWFLAKE_PASSWORD: ${{ secrets.SNOWFLAKE_PASSWORD }}
-  #       SNOWFLAKE_ACCOUNT: ${{ secrets.SNOWFLAKE_ACCOUNT }}
-  #   - run: cd runner && go test -race -coverprofile ../coverage/gounit.cov
-  #   - run: ./runner/scripts/test_coverage.sh
-
-  # e2e-linux:
-  #   runs-on: ubuntu-latest
-
-  #   steps:
-  #   - uses: actions/checkout@master
-  #     with:
-  #       ref: ${{ github.ref }}
-
-  #   # FROM: https://github.com/actions/cache/blob/main/examples.md#node---yarn
-  #   - name: Get yarn cache directory path
-  #     id: yarn-cache-dir-path
-  #     run: echo "::set-output name=dir::$(yarn cache dir)"
-
-  #   - uses: actions/cache@v2
-  #     id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
-  #     with:
-  #       path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
-  #       key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
-  #       restore-keys: |
-  #         ${{ runner.os }}-yarn-
-  #   - run: ./scripts/ci/prepare_linux.sh
-  #   - run: yarn release-desktop 0.0.0-e2etest
-  #   - run: git reset --hard # release blows everything up
-  #     # Set up a virtual framebuffer so Chrome will start
-  #     # https://www.electronjs.org/docs/tutorial/testing-on-headless-ci
-  #     # https://github.com/juliangruber/browser-run/issues/147
-  #   - run: xvfb-run --auto-servernum yarn e2e-test
-
-  # e2e-macos:
-  #   runs-on: macos-latest
-
-  #   steps:
-  #   - uses: actions/checkout@master
-  #     with:
-  #       ref: ${{ github.ref }}
-
-  #   # FROM: https://github.com/actions/cache/blob/main/examples.md#node---yarn
-  #   - name: Get yarn cache directory path
-  #     id: yarn-cache-dir-path
-  #     run: echo "::set-output name=dir::$(yarn cache dir)"
-
-  #   - uses: actions/cache@v2
-  #     id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
-  #     with:
-  #       path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
-  #       key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
-  #       restore-keys: |
-  #         ${{ runner.os }}-yarn-
-  #   - run: ./scripts/ci/prepare_macos.sh
-  #   # Needed so we can have ./build/desktop_runner.js ready for tests
-  #   - run: yarn build-test-runner
-  #   # https://github.com/golang/go/issues/49138 bug in macos -race detector
-  #   - run: MallocNanoZone=0 yarn test --detectOpenHandles --forceExit --verbose shared ui desktop
-  #   - run: cd runner && MallocNanoZone=0 go test -race -cover
-  #   - run: yarn release-desktop 0.0.0-e2etest
-  #   - run: git reset --hard # release blows everything up
-  #   - run: yarn e2e-test
-
-  # e2e-windows:
-  #   runs-on: windows-latest
-
-  #   steps:
-  #   - uses: actions/checkout@master
-  #     with:
-  #       ref: ${{ github.ref }}
-
-  #   # FROM: https://github.com/actions/cache/blob/main/examples.md#node---yarn
-  #   - name: Get yarn cache directory path
-  #     id: yarn-cache-dir-path
-  #     run: echo "::set-output name=dir::$(yarn cache dir)"
-
-  #   - uses: actions/cache@v2
-  #     id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
-  #     with:
-  #       path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
-  #       key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
-  #       restore-keys: |
-  #         ${{ runner.os }}-yarn-
-  #   - run: ./scripts/ci/prepare_windows.ps1
-  #     shell: pwsh
-  #   # Needed so we can have ./build/desktop_runner.js ready for tests
-  #   - run: yarn build-test-runner
-  #   - run: yarn test --detectOpenHandles --forceExit --verbose shared ui desktop
-  #   - run: cd runner && go test -race -cover
-  #   - run: yarn release-desktop 0.0.0-e2etest
-  #   - run: git reset --hard # release blows everything up
-  #   - run: yarn e2e-test
+  test:
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@master
+      with:
+        ref: ${{ github.ref }}
+
+    # FROM: https://github.com/actions/cache/blob/main/examples.md#node---yarn
+    - name: Get yarn cache directory path
+      id: yarn-cache-dir-path
+      run: echo "::set-output name=dir::$(yarn cache dir)"
+
+    - uses: actions/cache@v2
+      id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
+      with:
+        path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
+        key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
+        restore-keys: |
+          ${{ runner.os }}-yarn-
+    - run: ./scripts/ci/prepare_linux.sh --integration-tests
+    - run: yarn format
+    - run: yarn eslint ui
+    - run: yarn tsc
+    - run: cd runner && gofmt -w .
+    - run: yarn build-language-definitions
+    - run: ./scripts/fail_on_diff.sh
+    - run: yarn test-licenses
+    # Needed so we can have ./build/desktop_runner.js and ./build/go_desktop_runner ready for tests
+    - run: yarn build-test-runner
+    - run: yarn test --detectOpenHandles --forceExit --verbose
+      env:
+        AIRTABLE_TOKEN: ${{ secrets.AIRTABLE_TOKEN }}
+        AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
+        AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+        BIGQUERY_TOKEN: ${{ secrets.BIGQUERY_TOKEN }}
+        SNOWFLAKE_USER: ${{ secrets.SNOWFLAKE_USER }}
+        SNOWFLAKE_PASSWORD: ${{ secrets.SNOWFLAKE_PASSWORD }}
+        SNOWFLAKE_ACCOUNT: ${{ secrets.SNOWFLAKE_ACCOUNT }}
+    - run: cd runner && go test -race -coverprofile ../coverage/gounit.cov
+    - run: ./runner/scripts/test_coverage.sh
+
+  e2e-linux:
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@master
+      with:
+        ref: ${{ github.ref }}
+
+    # FROM: https://github.com/actions/cache/blob/main/examples.md#node---yarn
+    - name: Get yarn cache directory path
+      id: yarn-cache-dir-path
+      run: echo "::set-output name=dir::$(yarn cache dir)"
+
+    - uses: actions/cache@v2
+      id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
+      with:
+        path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
+        key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
+        restore-keys: |
+          ${{ runner.os }}-yarn-
+    - run: ./scripts/ci/prepare_linux.sh
+    - run: yarn release-desktop 0.0.0-e2etest
+    - run: git reset --hard # release blows everything up
+      # Set up a virtual framebuffer so Chrome will start
+      # https://www.electronjs.org/docs/tutorial/testing-on-headless-ci
+      # https://github.com/juliangruber/browser-run/issues/147
+    - run: xvfb-run --auto-servernum yarn e2e-test
+
+  e2e-macos:
+    runs-on: macos-latest
+
+    steps:
+    - uses: actions/checkout@master
+      with:
+        ref: ${{ github.ref }}
+
+    # FROM: https://github.com/actions/cache/blob/main/examples.md#node---yarn
+    - name: Get yarn cache directory path
+      id: yarn-cache-dir-path
+      run: echo "::set-output name=dir::$(yarn cache dir)"
+
+    - uses: actions/cache@v2
+      id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
+      with:
+        path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
+        key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
+        restore-keys: |
+          ${{ runner.os }}-yarn-
+    - run: ./scripts/ci/prepare_macos.sh
+    # Needed so we can have ./build/desktop_runner.js ready for tests
+    - run: yarn build-test-runner
+    # https://github.com/golang/go/issues/49138 bug in macos -race detector
+    - run: MallocNanoZone=0 yarn test --detectOpenHandles --forceExit --verbose shared ui desktop
+    - run: cd runner && MallocNanoZone=0 go test -race -cover
+    - run: yarn release-desktop 0.0.0-e2etest
+    - run: git reset --hard # release blows everything up
+    - run: yarn e2e-test
+
+  e2e-windows:
+    runs-on: windows-latest
+
+    steps:
+    - uses: actions/checkout@master
+      with:
+        ref: ${{ github.ref }}
+
+    # FROM: https://github.com/actions/cache/blob/main/examples.md#node---yarn
+    - name: Get yarn cache directory path
+      id: yarn-cache-dir-path
+      run: echo "::set-output name=dir::$(yarn cache dir)"
+
+    - uses: actions/cache@v2
+      id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
+      with:
+        path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
+        key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
+        restore-keys: |
+          ${{ runner.os }}-yarn-
+    - run: ./scripts/ci/prepare_windows.ps1
+      shell: pwsh
+    # Needed so we can have ./build/desktop_runner.js ready for tests
+    - run: yarn build-test-runner
+    - run: yarn test --detectOpenHandles --forceExit --verbose shared ui desktop
+    - run: cd runner && go test -race -cover
+    - run: yarn release-desktop 0.0.0-e2etest
+    - run: git reset --hard # release blows everything up
+    - run: yarn e2e-test
 
   test-server:
     runs-on: ubuntu-latest