Bump datastation

[0michalsokolowski0]

• Bump github.com/multiprocessio/datastation/runner (adding support for LogFmt logs)
• Add test for LogFmt

[eatonphil]

Looks good! Could you please add a test (and test file) see https://github.com/multiprocessio/dsq/pull/82/files for an example.

[0michalsokolowski0]

Added the test

[eatonphil]

Yeah, this is failing on Windows for some reason. If you have a Windows machine feel free to debug there otherwise I'll get to it sometime :D

[0michalsokolowski0]

I think I found two bugs here:

1. From the error we can see that the command that is called looks like this:
   Command '['cat', '.\\testdata\\logfmt\\log.txt', '|', '.\\dsq.exe', '-s', 'text\\logfmt', 'SELECT level FROM {}']
   The most interesting part here is 'text\logfmt' found here when running on Windows we are replacing all / with \\ as a result text/logfmt becomes text\\logfmt

To avoid this we could replace:
if WIN and not doNotReplaceWin: for i, piece in enumerate(pieces): pieces[i] = piece.replace('./dsq', './dsq.exe').replace('/', '\\')
With:
if WIN and not doNotReplaceWin: for i, piece in enumerate(pieces): if piece.startswith('./dsq'): pieces[i] = piece.replace('./dsq', './dsq.exe') elif piece.startswith('./'): pieces[i] = piece.replace('/', '\\')

2. After I changed the code locally another issue popped up: Unknown mimetype for file: <file_path>.
   The reason for this issue is that here we are calling resolveContentType which has a condition that looks strange on Windows.
   fileExtensionOrContentType is equal to text/logfmt and we are checking if it contains a separtor \\.
   Obviously it returns false and as a result UnknownMimeType is eventually returned.

I am not sure I understand the purpose of the condition strings.Contains(fileExtensionOrContentType, string(filepath.Separator)) I think what is should do is checking if the provided string is equal to a supported mime type and in that case return it.

If my interpretation is correct I would refactor MimeType in Datastation to have a function checking if a string can directly be mapped from string like: NewMimeTypeFromString(s string)

[eatonphil]

@0michalsokolowski0 great work investigating this!

Let's avoid this for now by adding support for recognizing a .logfmt extension in DataStation here: https://github.com/multiprocessio/datastation/blob/main/runner/file.go#L584. I want to have this anyway. This way you can just ./dsq log.logfmt blah instead of cat logfmt.txt | ./dsq -s text/logfmt.

[0michalsokolowski0]

@eatonphil Could you take a look https://github.com/multiprocessio/datastation/pull/286/files?

[eatonphil]

Great work!