Fix engineSetPoolCapacity crash (#3413)

multitheftauto · Jun 2, 2024 · 6702200 · 6702200
1 parent b6216ca
commit 6702200
Show file tree

Hide file tree

Showing 6 changed files with 39 additions and 6 deletions.
diff --git a/Client/game_sa/CBuildingsPoolSA.cpp b/Client/game_sa/CBuildingsPoolSA.cpp
@@ -246,6 +246,7 @@ bool CBuildingsPoolSA::Resize(int size)
     pGame->GetPools()->GetDummyPool().UpdateBuildingLods(oldPool, newObjects);
 
     RemoveVehicleDamageLinks();
+    RemovePedsContactEnityLinks();
 
     return true;
 }
@@ -310,6 +311,27 @@ void CBuildingsPoolSA::RemoveVehicleDamageLinks()
     }
 }
 
+void CBuildingsPoolSA::RemovePedsContactEnityLinks()
+{
+    const int count = pGame->GetPools()->GetPedCount();
+    for (int i = 0; i < count; i++)
+    {
+        auto* pedLinks = pGame->GetPools()->GetPed(i);
+        if (pedLinks->pEntity)
+        {
+            CPedSAInterface* ped = pedLinks->pEntity->GetPedInterface();
+            ped->m_pCollidedEntity = nullptr;
+            ped->pContactEntity = nullptr;
+            ped->pLastContactedEntity[0] = nullptr;
+            ped->pLastContactedEntity[1] = nullptr;
+            ped->pLastContactedEntity[2] = nullptr;
+            ped->pLastContactedEntity[3] = nullptr;
+            ped->m_ucCollisionState = 0;
+            ped->pTargetedEntity = nullptr;
+        }
+    }
+}
+
 bool CBuildingsPoolSA::HasFreeBuildingSlot()
 {
     return (*m_ppBuildingPoolInterface)->GetFreeSlot() != -1;

diff --git a/Client/game_sa/CBuildingsPoolSA.h b/Client/game_sa/CBuildingsPoolSA.h
@@ -37,6 +37,7 @@ class CBuildingsPoolSA : public CBuildingsPool
     void UpdateIplEntrysPointers(uint32_t offset);
     void UpdateBackupLodPointers(uint32_t offset);
     void RemoveVehicleDamageLinks();
+    void RemovePedsContactEnityLinks();
 
 private:
     SPoolData<CBuildingSA, CBuildingSAInterface, MAX_BUILDINGS> m_buildingPool;

diff --git a/Client/game_sa/CPedSA.cpp b/Client/game_sa/CPedSA.cpp
@@ -191,7 +191,7 @@ CVehicle* CPedSA::GetVehicle()
 {
     if (((CPedSAInterface*)GetInterface())->pedFlags.bInVehicle)
     {
-        CVehicleSAInterface* vehicle = (CVehicleSAInterface*)(((CPedSAInterface*)GetInterface())->CurrentObjective);
+        CVehicleSAInterface* vehicle = (CVehicleSAInterface*)(((CPedSAInterface*)GetInterface())->pVehicle);
         if (vehicle)
         {
             SClientEntity<CVehicleSA>* pVehicleClientEntity = pGame->GetPools()->GetVehicle((DWORD*)vehicle);

diff --git a/Client/game_sa/CPedSA.h b/Client/game_sa/CPedSA.h
@@ -209,6 +209,8 @@ class CPedWeaponAudioEntitySAInterface
 public:
 };
 
+class CVehicleSAInterface;
+
 class CPedSAInterface : public CPhysicalSAInterface            // +1420  = current vehicle   312 first byte
 {
 public:
@@ -239,11 +241,17 @@ class CPedSAInterface : public CPhysicalSAInterface            // +1420  = curre
     float               fCurrentRotation;
     float               fTargetRotation;
     float               fRotationSpeed;
-    BYTE                bPad8[4];
-    CEntitySAInterface* pContactEntity;
-    BYTE                bPad3[32];
-    CEntitySAInterface* CurrentObjective;            // current vehicle    1420
-    BYTE                bPad2[8];                    // 1424
+    float               fMoveAnim;
+    CPedSAInterface*    unkPed;
+    CVector             unk_56C;
+    CVector             unk_578;
+
+    CEntitySAInterface*  pContactEntity;
+    CVehicleSAInterface* pLastVehicle;
+    CVehicleSAInterface* pVehicle;
+
+    int                 unk_590;
+    int                 unk_594;
     BYTE                bPedType;                    // ped type? 0 = player, >1 = ped?  // 1432
     BYTE                bPad9[7];
     CWeaponSAInterface  Weapons[WEAPONSLOT_MAX];

diff --git a/Client/game_sa/CPoolsSA.h b/Client/game_sa/CPoolsSA.h
@@ -65,6 +65,7 @@ class CPoolsSA : public CPools
 public:
     void                   RemovePed(CPed* ped, bool bDelete = true);
     SClientEntity<CPedSA>* GetPed(DWORD* pGameInterface);
+    SClientEntity<CPedSA>* GetPed(size_t pos) { return &m_pedPool.arrayOfClientEntities[pos]; };
     CPed*                  GetPedFromRef(DWORD dwGameRef);
     CPedSAInterface*       GetPedInterface(DWORD dwGameRef);            // game_sa specific
     unsigned long          GetPedCount() { return m_pedPool.ulCount; }

diff --git a/Client/sdk/game/CPools.h b/Client/sdk/game/CPools.h
@@ -86,6 +86,7 @@ class CPools
     virtual void  RemovePed(CPed* pPed, bool bDelete = true) = 0;
 
     virtual SClientEntity<CPedSA>* GetPed(DWORD* pGameInterface) = 0;            // not sure we really want this here
+    virtual SClientEntity<CPedSA>* GetPed(size_t pos) = 0;
     virtual CPed*                  GetPedFromRef(DWORD dwGameRef) = 0;
     virtual unsigned long          GetPedCount() = 0;