Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onClientPlayerWeaponSwitch should trigger for remote players #1141

Closed
srslyyyy opened this issue Oct 29, 2019 · 1 comment
Closed

onClientPlayerWeaponSwitch should trigger for remote players #1141

srslyyyy opened this issue Oct 29, 2019 · 1 comment
Labels
enhancement New feature or request
Projects
Proposals
Milestone
Backlog

Comments

@srslyyyy
Copy link
Contributor

Is your feature request related to a problem? Please describe.
onClientPlayerWeaponSwitch doesn't trigger when weapon slot is changed for remote players.

Describe the solution you'd like
It should trigger also for remote players. If possible.

Describe alternatives you've considered
At the moment, there's no possibility to detect changes for weapon slot, the only possibility is using loop. (for render usage f.e)

Additional context
It would be very nice, if we could detect those changes on client-side by event provided by MTA.
I think this is possible to do, since onClientPlayerWeaponFire triggers for local/remote player.
@srslyyyy srslyyyy added the enhancement New feature or request label Oct 29, 2019
@sbx320
Copy link
Member

sbx320 commented Nov 1, 2019

We'd probably need a new event name, as scripts may rely on the event triggering only for the local player.

@correaAlex correaAlex mentioned this issue Nov 1, 2019
Closed
@qaisjp qaisjp added this to Incoming in Proposals via automation Mar 14, 2020
@qaisjp qaisjp moved this from Incoming to Accepted in Proposals Mar 14, 2020
@patrikjuvonen patrikjuvonen linked a pull request Mar 31, 2021 that will close this issue
Add onClientPlayerWeaponSwitch for remote players #1723
Closed
@patrikjuvonen patrikjuvonen added this to the Backlog milestone Mar 31, 2021
@patrikjuvonen patrikjuvonen linked a pull request Apr 10, 2021 that will close this issue
Add onClientPedWeaponSwitch #2181
Closed
@znvjder znvjder mentioned this issue Nov 11, 2023
Merged
@Dutchman101 Dutchman101 mentioned this issue May 23, 2024
Merged
MTABot pushed a commit that referenced this issue May 23, 2024
@github-actions
Synchronize changes from 1.6 master branch [ci skip]
89a971e 
c4d63b4 Trigger onClientPlayerWeaponSwitch Event for Remote Players (fix #1141) (#3291)
Dutchman101 added a commit that referenced this issue May 23, 2024
@Dutchman101
Revert "Trigger onClientPlayerWeaponSwitch Event for Remote Players (fix
032dbd3 
 #1141) (#3291)"

This reverts commit c4d63b4.
For details, see comment on PR #3291
MTABot pushed a commit that referenced this issue May 23, 2024
@github-actions
Synchronize changes from 1.6 master branch [ci skip]
3fd9837 
032dbd3 Revert "Trigger onClientPlayerWeaponSwitch Event for Remote Players (fix #1141) (#3291)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Proposals
  
Accepted
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Add onClientPlayerWeaponSwitch for remote players
Add onClientPedWeaponSwitch
3 participants
@sbx320 @patrikjuvonen @srslyyyy