-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caddy (vehicle) plays incorrect door/entry animation #1318
Comments
Tractor as well you know when you normally enter a vehicle, and door remains open, so when you let go of W, the player closes the door automatically by also doing animation of doing it? |
Just to show it off better, here's a video demonstration: |
Thank you so much for the video! Please can you install https://nightly.mtasa.com/mtasa-1.5.7-rc-20417-20200301.exe and check if that still happens? |
That fixed it. Both Caddy and Tractor act normal now. |
Thanks for confirming. Okay, definitely a VS 2019 problem. Release the kraken! |
Uh, problem reappeared in version 20488 |
No.. it just hasn't been fixed yet, the build you tested with (which you said "fixed" it) was simply an old build from before upgrading to VS2019. This is probably undefined behavior somewhere that gets exposed with VS2019 only, and it needs to be located in order to get fixed. |
Does the bug occur with a custom (debug or release) build? |
I can reproduce it on both, and sometimes this happens: https://cdn.discordapp.com/attachments/366384007535001612/725386799610069083/2020-06-24_21-23-39.mp4 |
Many more vehicles are affected.. for example, kart, mower, vortex, bandito, baggage.. the list goes on beyond that. It seems like all vehicles without door are affected, those with "jump (or step) right in" animation. @ccw808 if there's any GTA hook optimization in netcode like last time with a similar hard-to-locate VS2019 bug, this information can help narrow it down? |
I think the problem is in the OS code |
This issue is caused by c2dc463 and is not related to VS2019 |
This is strange. I can still reproduce this bug. |
there is no error, the client: 20621 server: 20624 |
yes
I was using the old server build. Full rebuild fixed the issue. |
Describe the bug
When entering Golf Caddy ID 457, it plays a door opening animation both when entering from passenger and driver side.
To reproduce
Expected behaviour
The player should enter the vehicle by directly stepping inside.
Screenshots
N/A
Version
Client: Multi Theft Auto v1.5.7-release-20460
Additional context
Qaisjp suspects the vs2019 issue may be related
Strix later found the answer, #1318 (comment)
The text was updated successfully, but these errors were encountered: