Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Discord rich presence API #1335

Closed
qaisjp opened this issue Mar 30, 2020 · 1 comment
Closed

Fix Discord rich presence API #1335

qaisjp opened this issue Mar 30, 2020 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed refactor
Milestone
1.6.0

Comments

@qaisjp
Copy link
Contributor

qaisjp commented Mar 30, 2020 •
edited

Describe the bug

The name setPlayerDiscordJoinParams is temporary and we need to come up with something that is more platform agnostic

Or allow a server to "require" a discord package and do Discord-specific stuff within that module (but only if that module is available).

Additional context

Filing this as an issue so that we sort it out before releasing 1.6.
@qaisjp qaisjp added the bug Something isn't working label Mar 30, 2020
@qaisjp qaisjp added this to the 1.6 milestone Mar 30, 2020
@qaisjp qaisjp added enhancement New feature or request refactor and removed bug Something isn't working labels Mar 30, 2020
@qaisjp qaisjp pinned this issue Apr 10, 2020
@qaisjp qaisjp added the help wanted Extra attention is needed label Apr 10, 2020
@qaisjp qaisjp modified the milestones: 1.5.8, 1.6 Apr 20, 2020
@qaisjp qaisjp mentioned this issue Apr 25, 2020
Closed
@qaisjp qaisjp unpinned this issue May 19, 2020
@qaisjp qaisjp closed this as completed Dec 29, 2020
@patrikjuvonen patrikjuvonen reopened this Dec 29, 2020
@botder botder modified the milestones: Next Release, Next Stage Feb 6, 2021
@patrikjuvonen
Copy link
Contributor

Closed in favor of #2499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed refactor
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
3 participants
@qaisjp @patrikjuvonen @botder